Problem/Motivation

I noticed that in 3.0.0-rc6 there is a regression with wrong padding in Inline Entity Form fields, and the same is with rc7 and the last dev version, here are the screenshots:
rc5
rc6

Steps to reproduce

1. Install the Inline Entity Form module
2. Configure the "Tags" field in "Article" content to use the "Inline entity form - simple" widget.
3. Open the "Add new article" form and see the problem.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#15 After-mr-378.png442.64 KBdjsagar
#12 after.png36.87 KBrupeshghar
#12 before.png38.21 KBrupeshghar
#9 issue.png428 KBdjsagar
#7 authored_by.png19.75 KBrenukakulkarni
#5 authored_by.png8.83 KBrenukakulkarni
#5 space-issue-for-form-fields-3401158-7.patch740 bytesrenukakulkarni
ksnip_20231113-115805.png19.94 KBmurz
ksnip_20231113-115803.png18.85 KBmurz

Issue fork gin-3401158

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Murz created an issue. See original summary.

murz’s picture

murz
Primary language English
Location Yerevan, Armenia
commented
Issue summary: View changes
saschaeggi’s picture

saschaeggi
he/him
commented
Related issues: +#3340478: Space issue between inline entity form fields

Are the changes from #3340478: Space issue between inline entity form fields missing? Were you able to narrow it down what causes this regression?

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Active » Postponed (maintainer needs more info)
renukakulkarni’s picture

renukakulkarni commented
StatusFileSize
new space-issue-for-form-fields-3401158-7.patch740 bytes
new authored_by.png8.83 KB

This issue was caused because the margin area on the bottom of a form item was removed for this issue - https://www.drupal.org/project/gin/issues/3375729 (https://git.drupalcode.org/project/gin/-/commit/0f4f88aef90989f49a91c89e...) This has affected the space between the form items.

I have checked the autocomplete field behavior after applying the code changes from the provided patch. It does not seem to be creating any issues, at least with the fields highlighted in the screenshot under this issue - https://www.drupal.org/project/gin/issues/3375729, and that fixes the space issue between the form items as well.
autocomplete_field

renukakulkarni’s picture

renukakulkarni commented
Status: Postponed (maintainer needs more info) » Needs review
renukakulkarni’s picture

renukakulkarni commented
StatusFileSize
new authored_by.png19.75 KB
djsagar’s picture

djsagar commented
Status: Needs review » Needs work
Issue tags: +Needs steps to reproduce

Hi all not able to reproduce this issue in 8.x-3 gin theme.

Please provide more details.

Updating tag and moving NW.

djsagar’s picture

djsagar commented
Issue tags: -Needs steps to reproduce
StatusFileSize
new issue.png428 KB

Removing tag able to reproduce above issue.

Steps to reproduce
1. Install the Inline Entity Form module
2. Configure the "Tags" field in "Article" content to use the "Inline entity form - simple" widget.
3. Open the "Add new article" form and see the problem path => /node/add/article

Issue.
issue

Proposed resolution

We need to override margin top 

tr .form-item {
    margin-top: 0;
    margin-bottom: 0;
}
rupeshghar’s picture

rupeshghar commented
Assigned: Unassigned » rupeshghar

rupeshghar opened merge request !378

rupeshghar’s picture

rupeshghar commented
Assigned: rupeshghar » Unassigned
Status: Needs work » Needs review
StatusFileSize
new before.png38.21 KB
new after.png36.87 KB

Overriden default css written on form-item and raised MR for same

sdhruvi5142’s picture

sdhruvi5142 commented
Assigned: Unassigned » sdhruvi5142
djsagar’s picture

djsagar commented
Assigned: sdhruvi5142 » Unassigned
djsagar’s picture

djsagar commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new After-mr-378.png442.64 KB

Applied MR !378, working as expected.
Moving into the RTBC +

After MR
After MR

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Closed (outdated)

I believe this is outdated as of now with recent changes.

Feel free to reopen if that's not the case please!

xenophyle’s picture

xenophyle commented
Status: Closed (outdated) » Reviewed & tested by the community

I updated to the 8.x-3.1.0 and I'm still seeing the lack of margin. The MR made it better. It's still tighter than fields that are not in the table, but maybe it is that way for a reason.