Enable modules through Nightwatch API when not testing module enabling

Change seems good.

Searched for .drupalRelativeURL('/admin/modules') and saw the 2 instances were updated.

Hopefully this helps move nightwatch tests to be more useable.

Good idea, we have the API so let's use it! Backported to 10.2.x to keep tests in sync.

Committed and pushed a2f51b88d5 to 11.x and 977e680afb to 10.2.x. Thanks!

reverted

Unfortunately this resulted in a flood of Nightwatch errors in modules/ckeditor5/tests/src/Nightwatch/Tests/ckEditor5CodeSyntaxTest.js - I could not get this to pass locally without reverting this.

I suspect this is due to async and perform doing a retry and things getting very broken.

Modified drupalInstallModule() so it can install more than one module at a time.

I don't even think the test needs Field UI, we could just remove that, but we should probably fix the multiple-install issue while we are here?

Yeah swapping the order of the modules being installed in before(browser) { completely breaks the modules/ckeditor5/tests/src/Nightwatch/Tests/ckEditor5CodeSyntaxTest.js locally.

Also what is super fun is that core/modules/ckeditor5/tests/src/Nightwatch/Tests/ckEditor5EditorHeightTest.js does not fail :) It tries to enable 2 modules… and again because the test does not actually need field ui it is fine. But

    // Set fixed (desktop-ish) size to ensure a maximum viewport.
    browser.resizeWindow(1920, 1080);

somehow makes it pass.

We need to do here is add a test for enabling multiple modules via something like

    browser
      .drupalInstall({ installProfile: 'minimal' })
      .drupalInstallModule('ckeditor5', true)
      .drupalInstallModule('field_ui');

in the before section and then go to the module screen and see if they are installed. Because drupalInstallModule should be chainable.

Seems to be because drupalInstallModule() does not wait for anything. If you remove this:

  .perform(() => {
    if (typeof callback === 'function') {
      callback.call(self);
    }
  })

then field_ui is installed *after* the test runs!

If I add .waitForElementPresent('body') before or after .perform() then it seems to pass consistently.

To add to that, think why a lot of people probably don't contribute it's very difficult to get running locally.

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Fun stuff, I've been working with Nightwatch a bit lately, and honestly I don't see an added value for it in the Drupal sphere.

I am wondering when the last time was we added any test coverage vs. dealing with nightwatch failures. Should probably open a new issue to discuss whether we want to think about removing it.

Re removing Nightwatch - it is doing somethings our PHP based JS testing framework cannot do.

• usability testing use Axe - see core/tests/Drupal/Nightwatch/Tests/a11yTestDefault.js
• JS unit testing - see core/modules/ckeditor5/tests/src/Nightwatch/Tests/drupalHtmlBuilderTest.js

In the scope of the Test Helpers module, I implemented a Nightwatch command thInstallModules() that installs one or even several modules at once on the Drupal side without any click in the browser - it works 1000 times quicker than clicking in the browser (log in as admin, go to modules, etc.), cus does just one GET request in the background and that's it. Here it is: https://git.drupalcode.org/project/test_helpers/-/blob/1.5.x/tests/modul...

Via the same way, we can optimize any other popular actions for tests, so I already implemented more Nightwatch commands too:
thDrupalFetchURL(), thInstallModules(array) thSetConfig(), thLogout(), etc.

You can look at the usage examples in the Commercetools module's Nightwatch tests.

So, maybe let's implement the same functions, but in Drupal Core?

Another way to speed up installing and enabling modules is creating test profiles, where just list all required modules. Also, we can deploy the required configuration from this test profile. And even more, using the install hook, we can add more backend PHP magic there, that is needed for tests.

See https://git.drupalcode.org/project/commercetools/-/blob/2.0.x/modules/co...
and https://git.drupalcode.org/project/commercetools/-/blob/2.0.x/tests/prof... as examples.

By the way, here #3464642: [PP-1] Provide PHP helpers for Nightwatch tests to speed up routine operations is a more general issue about such Nightwatch helpers.