Postponed
Project:
Drupal core
Version:
main
Component:
configuration system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Sep 2023 at 11:40 UTC
Updated:
16 Dec 2023 at 12:56 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
wim leersRepurposing per #3364506-103: Add optional validation constraint support to ConfigFormBase and [-105].
Comment #3
wim leersComment #4
wim leers#3364506: Add optional validation constraint support to ConfigFormBase landed!
#3382510: Introduce a new #config_target Form API property to make it super simple to use validation constraints on simple config forms, and adopt it in several core config forms is in review.
Comment #5
wim leers#3382510: Introduce a new #config_target Form API property to make it super simple to use validation constraints on simple config forms, and adopt it in several core config forms landed. That means this is now only blocked on #3384790: Update all remaining ConfigFormBase subclasses in Drupal core to use #config_target 🚀
Comment #6
wim leersComment #7
wim leers#5 didn't explain how we could implement this deprecation in the
>=10.2.xworld.Thanks to #3398891: Do not require the config in #config_target to be listed in getEditableConfigNames(), I see how we can now do that:
I propose that we make
ConfigFormBasedetect:getEditableConfigNames()returns anything other than the empty arrayTricky thing here: for example
\Drupal\search\SearchPageListBuilderuses not the base class, but the trait … and the trait does NOT have the#config_targetfunctionality 🤔AFAICT we'll need to deprecate in Drupal 11 only
\Drupal\Core\Form\ConfigFormBase::getEditableConfigNames, not\Drupal\Core\Form\ConfigFormBaseTrait::getEditableConfigNames?Tricky edge case: already (thanks to #3398891), a number of subclasses do not implement that method at all, and instead
use RedundantEditableConfigNamesTrait;. That trait will become obsolete too!Finally: is this issue now effectively a duplicate of #3400033: Deprecate \Drupal\Core\Form\ConfigFormBase::getEditableConfigNames() - use #config_target instead? Or vice versa?
Comment #8
borisson_Closed #3384782: [PP-1] Follow-up for #3364506: add deprecation once all simple config forms in core implement in favor of this issue.