FILE: /var/www/html/contribution/web/modules/contrib/remix/src/Form/SettingsForm.php
------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------
42 | WARNING | Possible useless method overriding detected
------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/remix/remix.module
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Missing function doc comment
12 | WARNING | [x] '@TODO: Make this as part of the settings/configuration form.' should match the format '@todo Fix problem X here.'
14 | ERROR | [x] There should be no white space after an opening "("
14 | ERROR | [x] There should be no white space before a closing ")"
47 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#7 fixed-phpcs-issue-3353614-1.patch1.43 KBhimanshu_jhaloya

Issue fork remix-3353614

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

himanshu_jhaloya created an issue. See original summary.

himanshu_jhaloya opened merge request !1

himanshu_jhaloya’s picture

himanshu_jhaloya commented
Assigned: himanshu_jhaloya » Unassigned
Status: Active » Needs review

jmolivas made their first commit to this issue’s fork.

jmolivas’s picture

jmolivas commented

Hi @himanshu_jhaloya thanks for the MR, can you try rebasing locally and push it again not sure why is not allowing me to merge this.

jmolivas’s picture

jmolivas commented
Status: Needs review » Needs work
himanshu_jhaloya’s picture

himanshu_jhaloya commented
Status: Needs work » Needs review
StatusFileSize
new fixed-phpcs-issue-3353614-1.patch1.43 KB

created the patch please review.

jmolivas’s picture

jmolivas commented
Status: Needs review » Fixed

Thanks for the MR @himanshu_jhaloya

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: -Fix the issues reported by phpcs +Coding standards

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.