Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

omkar.podey created an issue. See original summary.

wim leers’s picture

Status: Active » Needs work
Testing Drupal\Tests\package_manager\Kernel\StageTest
.......................F.                                         25 / 25 (100%)

Time: 00:39.430, Memory: 6.00 MB

There was 1 failure:

1) Drupal\Tests\package_manager\Kernel\StageTest::testFailureCollectIgnoredPaths
Failed asserting that exception message 'No composer.json file can be found at vfs://root/active
' contains 'Composer could not find the config file: vfs://root/active/composer.json
'.
wim leers’s picture

Status: Needs work » Closed (duplicate)

See #3315834-46: GitExcluder should not ignore .git directories that belong to packages installed by Composer why this change does not make sense to land separately: some excluder is needed to trigger that case, so we might as well land this as part of #3315834.

omkar.podey’s picture

Status: Closed (duplicate) » Active
omkar.podey’s picture

left a comment here.

omkar.podey’s picture

Assigned: omkar.podey » Unassigned
Status: Active » Needs review
wim leers’s picture

Title: Add Error handling for \Drupal\package_manager\Stage::getIgnoredPaths » Add error handling for \Drupal\package_manager\Stage::getIgnoredPaths()
Status: Needs review » Needs work

This needs polish. 3 remarks on the MR. I like how the scope of this issue is far more manageable than the issue where this was discovered though 😄

wim leers’s picture

Assigned: Unassigned » omkar.podey
omkar.podey’s picture

Assigned: omkar.podey » wim leers
Status: Needs work » Needs review
wim leers’s picture

Assigned: wim leers » omkar.podey
Status: Needs review » Needs work

A few remarks to ensure the MR is clear — but we're definitely almost done!

omkar.podey’s picture

Assigned: omkar.podey » wim leers
Status: Needs work » Needs review
wim leers’s picture

wim leers’s picture

Assigned: wim leers » Unassigned
Status: Needs review » Reviewed & tested by the community

tedbow made their first commit to this issue’s fork.

  • tedbow committed b895fb24 on 8.x-2.x authored by omkar.podey
    Issue #3334054 by omkar.podey: Add error handling for \Drupal\...
tedbow’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.