We need to improve the query class to better support range queries (so we can eliminate e.g. function _hack_parse_date_range()). Also, we should improve the handling of the sort string so that field aliases work there.

CommentFileSizeAuthor
#11 ordering-fix-432946-11.patch982 bytespwolanin
#9 neg-fu-cleanup-432946-9.patch1.76 KBpwolanin
#7 cleanup-432946-7.patch39.39 KBpwolanin
#6 cleanup-432946-6.patch38.61 KBpwolanin
#5 cleanup-432946-5.patch37.2 KBpwolanin
#3 cleanup-432946-3.patch28.55 KBpwolanin
#1 cleanup-432946-1.patch22.74 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs work
StatusFileSize
new cleanup-432946-1.patch22.74 KB
pwolanin’s picture

pwolanin commented

The code might be simpler if we use PREG_SET_ORDER vs. the default PREG_PATTERN_ORDER

pwolanin’s picture

pwolanin commented
StatusFileSize
new cleanup-432946-3.patch28.55 KB
Scott Reynolds’s picture

Scott Reynolds commented

subs

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
StatusFileSize
new cleanup-432946-5.patch37.2 KB

More, much more. And it mostly works.

pwolanin’s picture

pwolanin commented
StatusFileSize
new cleanup-432946-6.patch38.61 KB

better still.

pwolanin’s picture

pwolanin commented
StatusFileSize
new cleanup-432946-7.patch39.39 KB

fixes a date facet bug, plus some more minor cleanup

pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

committed to 6.x

pwolanin’s picture

pwolanin commented
Status: Fixed » Needs review
StatusFileSize
new neg-fu-cleanup-432946-9.patch1.76 KB

follow-up patch for handling of negative queries (still breaks on field aliases, but with this at least works for book facets without field aliases)

pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

committed - but makes me think we need to really pull out the prefix as a separate attribute of each saved filter.

pwolanin’s picture

pwolanin commented
StatusFileSize
new ordering-fix-432946-11.patch982 bytes

committing one more very minor fix - we need a char before 0 in the ASCII table, not after.

pwolanin’s picture

pwolanin commented

further work here: http://drupal.org/node/436074

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.