If cron updates are disabled display a message if status checks fail after installing Automatic Updates

Doesn't this, like, already happen, though? In automatic_updates_modules_installed()? Or is that merely reacting to other modules being installed?

The relevant line from ModuleInstaller would seem to suggest that it's invoked even in the modules that were installed:

      $this->moduleHandler->invokeAll('modules_installed', [$modules_installed, $sync_status]);

Maybe all we really need here is better test coverage. Thoughts?

Confirmed with manual testing that, in fact, installing Automatic Updates DOES NOT run readiness checks in the UI. So this feature request is legitimate.

12 remarks on the MR 🤓

Last round of review from me; then the code will be clear. Then I'll RTBC and @tedbow can do the final review :)

Note: the issue summary still needs to be updated!

We need test coverage for tests/modules/automatic_updates_test_cron to verify it's behaviour in tests when the module is disabled.

We want to call displayResultSummary() from automatic_updates_modules_installed() in automatic_updates.module but the Enabler class in automatic_updates_test_cron is not called early enough to change default disabled cron update.

A work-around for #23 is possible.

6acc61cf failed like this:

Testing Drupal\Tests\automatic_updates\Functional\StatusCheckTest
E.......                                                            8 / 8 (100%)

Time: 01:11.554, Memory: 6.00 MB

There was 1 error:

1) Drupal\Tests\automatic_updates\Functional\StatusCheckTest::testModuleFormInstallDisplay with data set "Error" (2, true)
Behat\Mink\Exception\ResponseTextException: Failed asserting that the page matches the pattern '/Your site does not pass some readiness checks for automatic updates\. It cannot be automatically updated until further action is performed\./ui' 1 time(s), 2 found.
Failed asserting that 2 is identical to 1.

i.e. it expected that Your site does not pass some readiness checks for automatic updates appeared only once, but it appeared twice.

See commit 8105c059aae1413f037a4c99d1dcadbf9c9ce8d3.

Now it should fail like this:

1) Drupal\Tests\automatic_updates\Functional\StatusCheckTest::testModuleFormInstallDisplay with data set "Error" (2, true)
Behat\Mink\Exception\ExpectationException: Link with label See status report for more details. found.

/Users/wim.leers/core/core/tests/Drupal/Tests/WebAssert.php:560
/Users/wim.leers/core/core/tests/Drupal/Tests/WebAssert.php:318
/Users/wim.leers/core/modules/contrib/automatic_updates/tests/src/Functional/StatusCheckTest.php:105
/Users/wim.leers/core/vendor/phpunit/phpunit/src/Framework/TestResult.php:703

… because the test is AFAICT wrong.

Now testing doesn't contain the cases when cron updater is enabled, because we now we have default cron set to disable in automatic_updates.settings.yml and I think that will be the case whenever automatic_updates is enabled.

If there is a case when we want to simulate enabling automatic_updates with cron updates enabled then it's difficult because to enable cron updates in tests we need automatic_updates.settings.yml which won't be available until we have automatic_updates enabled.