At core 9.1 we get
PHP Fatal error: Declaration of Drupal\Tests\commerce\Functional\CommerceBrowserTestBase::tearDown() must be compatible with Drupal\Tests\BrowserTestBase::tearDown(): void in /var/www/html/modules/contrib/commerce/tests/src/Functional/CommerceBrowserTestBase.php on line 83
Change Record https://www.drupal.org/node/3114724
Adding the tearDown(): void type hint wiill require PHP7.1 minimum, although this only affects the test files.
this is complimentary to #3216989: [9.1] Declaring ::setUp without a void return typehint is deprecated
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3306470-2.patch | 1.43 KB | andypost |
Comments
Comment #2
andypostAs I get it should go 2.x and 3.x branches
This is real blocker for email_registration module https://www.drupal.org/pift-ci-job/2462113
Comment #3
andypost10.x still broken but the issue is blocker
Comment #6
jsacksick commentedIt's funny that this deprecation was introduced in Drupal core 9.1 as core 9.5 doesn't have the :void return type hint (See https://git.drupalcode.org/project/drupal/-/blob/10.0.x/core/tests/Drupa...).
But since tests are still passing with 9.x, I'm inclined to commit this, thanks for the patch.
Comment #7
andypostThank you! I really wondered how come but queued
- https://www.drupal.org/pift-ci-job/2462865
- https://www.drupal.org/pift-ci-job/2462866
Comment #8
andypostAlso added to CR https://www.drupal.org/node/3114724#comment-14671891
Comment #9
andypost