Problem/Motivation

Use https://www.drupal.org/project/config_inspector to validate the schema of a field using this view mode, for example:
field.field.paragraph.attachments.field_entity_viewmode

returns the following schema errors, which I think come from this module:

  • default_value.0.value Undefined undefined button missing schema
  • settings.exclude Undefined undefined missing schema
  • settings.negate Undefined undefined 1 missing schema

Steps to reproduce

  1. Install this module
  2. Add a entity_reference_display field to an entity
  3. Use https://www.drupal.org/project/config_inspector to inspect schema errors on that entity
  4. Find the issues above

Proposed resolution

Add a schema.yml to fix these issues.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 Screenshot from 2022-08-25 11-27-13.png20.09 KBvighneshh

Issue fork entity_reference_display-3305440

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes
vighneshh’s picture

vighneshh commented
Assigned: Unassigned » vighneshh

will work on it

Vighneshh opened merge request !1

vighneshh’s picture

vighneshh commented
Assigned: vighneshh » Unassigned
Status: Active » Needs review
StatusFileSize
new Screenshot from 2022-08-25 11-27-13.png20.09 KB

Few keypoints:
1. Make sure your cache are cleared when you run config_inspector
2. Adding a screenshot of config inspector results.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Missing schema » Update schema definition of the negate property
Status: Needs review » Reviewed & tested by the community

Thanks!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Needs work

Please STOP wasting your and everyone else's time by not fixing the root cause, but creating dirty workarounds.

"Negate" is a BOOLEAN, not an integer. If an integer is wrongly stored in there, take the time to find out why that happens instead of changing the schema to integer! Think first, act second.

See
https://git.drupalcode.org/project/entity_reference_display/-/blob/8.x-1...

And please don't set issues RTBC which are not solved cleanly, you're just opening the next issue circle...

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented

This discussion appears to discourage contribution from some participants by assuming a level of education or exposure to information. This can discourage folks that are new to a conversation from asking for help or getting involved. Consider providing the new contributor with links to help them learn the topic or concept.

For more information, please refer to Drupal’s Values and Principles #3 of fostering a learning environment: long-term contributors should be role models by admitting their own shortcomings and mistakes, being vulnerable, and by giving others the same respect that was once given to them. To keep learning read this article about not feigning surprise.

Principle #9 can also be useful here: be constructively honest, and relentlessly optimistic. You can be optimistic and supportive by giving suggestions for how to improve their contributions. By being helpful, you encourage people to accept feedback and act on it.

This comment is provided as a service (currently being tested) of the Drupal Community Health Team as part of a project to encourage all participants to engage in positive discourse. For more information, please visit https://www.drupal.org/project/drupal_cwg/issues/3129687

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks @volkswagenchick and sorry if my wording was too hard. Seems I was frustrated by the many times I saw patches and RTBC's like this in the last weeks. Of course, I'm happy about any helpful work in the Drupal project.

If this hadn't been RTBC'd I would have been okay with the wrong patch which is at least trying to fix this.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented

Here is a link to Issue Queue Etiquette that may be helpful when informing people about moving issue queue status

grevil’s picture

grevil commented
Status: Needs work » Closed (outdated)

Most of these schema definitions are already implemented in the current 2.0.x.
The "default_value" schema definition is implemented through #3432401: Add missing "default_value" schema definition for the "value" property. This issue can be closed.