Problem/Motivation

Policy issue that confirmed its deprecation in Drupal core 9.4.x. #1261120: Deprecate Tracker module in D10 and move to contrib in D11.

Steps to reproduce

Proposed resolution

Deprecate the module

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3261679

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha opened merge request !1758

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Active » Needs review
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Deprecate tracker module » Deprecate tracker module in Drupal 9.4
catch’s picture

catch
he/him
Primary language English
commented

Patch looks good.

We'll need a release on https://www.drupal.org/project/tracker and opt-in to security coverage before we can actually commit it.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

dww’s picture

dww
we/he/they
commented 
lifecycle_link: 'https://www.drupal.org/about/core/policies/core-change-policies/deprecated-and-obsolete-modules-and-themes#s-activity-tracker'

Do we have a standard for this? Given d.o's tendency to do sweeping content restructuring, I'm a little worried about encoding this specific path (and anchor) into core. Other patches just use the raw node/N for the lifecycle_link. That seems a bit more likely to survive future reshufflings.

Otherwise, RTBC++...

Thanks!
-Derek

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Postponed

Let's postpone this on #3257127: Trigger a deprecation message when a deprecated module or theme is enabled, and make sure that all tests that depend on tracker are within the module's own directory, then marked legacy, etc.

naveenvalecha’s picture

naveenvalecha
He/Him
commented

#5,

We'll need a release on https://www.drupal.org/project/tracker and opt-in to security coverage before we can actually commit it.

Done

#6,

Do we have a standard for this? Given d.o's tendency to do sweeping content restructuring, I'm a little worried about encoding this specific path (and anchor) into core. Other patches just use the raw node/N for the lifecycle_link. That seems a bit more likely to survive future reshufflings.

I am not sure about the standard but core already has its usage https://git.drupalcode.org/project/drupal/-/blob/9.4.x/core/modules/enti...

quietone’s picture

quietone commented
Status: Postponed » Needs review

No longer postponed.

quietone’s picture

quietone commented
Parent issue: » #3267080: [Meta] Tasks to deprecate Tracker
quietone’s picture

quietone commented
Issue tags: +Needs change record

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

spokje’s picture

spokje
Primary language Dutch
commented
Title: Deprecate tracker module in Drupal 9.4 » Deprecate tracker module in Drupal 9.5
Assigned: Unassigned » spokje
Status: Needs review » Needs work

Spokje opened merge request !2399

spokje’s picture

spokje
Primary language Dutch
commented
Title: Deprecate tracker module in Drupal 9.5 » [PP1] Deprecate tracker module in Drupal 9.5
Status: Needs work » Postponed
Related issues: +#3291265: \Drupal\Tests\forum\Functional\ForumNodeAccessTest doesn't use tracker module

Postponing on #3291265: \Drupal\Tests\forum\Functional\ForumNodeAccessTest doesn't use tracker module

spokje’s picture

spokje
Primary language Dutch
commented
Title: [PP1] Deprecate tracker module in Drupal 9.5 » [PP-1] Deprecate tracker module in Drupal 9.5
spokje’s picture

spokje
Primary language Dutch
commented
Title: [PP-1] Deprecate tracker module in Drupal 9.5 » [PP-2] Deprecate tracker module in Drupal 9.5
Related issues: +#3271124: Move all non migration Tracker tests to the module in preparation of removal

Turns out (I must remember to read the meta-issue first before diving into these issues...) this is postponed on:

#3271124: Move all non migration Tracker tests to the module in preparation of removal
#3291265: \Drupal\Tests\forum\Functional\ForumNodeAccessTest doesn't use tracker module

spokje’s picture

spokje
Primary language Dutch
commented
Title: [PP-2] Deprecate tracker module in Drupal 9.5 » [PP-1] Deprecate tracker module in Drupal 9.5

Blocker #3291265: \Drupal\Tests\forum\Functional\ForumNodeAccessTest doesn't use tracker module landed.

catch’s picture

catch
he/him
Primary language English
commented
Title: [PP-1] Deprecate tracker module in Drupal 9.5 » Deprecate tracker module in Drupal 9.5
Status: Postponed » Active

Possibly unblocked?

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs work

naveenvalecha closed merge request !1758

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs work » Needs review
Issue tags: -Needs change record

I was also about to update the PR, but you did you early than me :)
Updated CR https://www.drupal.org/node/3261453

spokje’s picture

spokje
Primary language Dutch
commented
Title: Deprecate tracker module in Drupal 9.5 » [PP-1] Deprecate tracker module in Drupal 9.5
Assigned: spokje » Unassigned
Status: Needs review » Postponed

Postponed on #3291599: Ensure that tracker does not get special core treatment per Slack discussion here: https://drupal.slack.com/archives/C014CT1CN1M/p1655750184381089

spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3291599: Ensure that tracker does not get special core treatment
quietone’s picture

quietone commented
Issue summary: View changes

Change that the referred issue is a policy issue.

spokje’s picture

spokje
Primary language Dutch
commented
Title: [PP-1] Deprecate tracker module in Drupal 9.5 » Deprecate tracker module in Drupal 9.5
Status: Postponed » Needs work

Blocker #3291599: Ensure that tracker does not get special core treatment landed, but realistically, I don't see this module making the full Deprecation/Removal Dance in time before the 9.5.0/10.0.0 beta cut-off date on September 2nd.

Happy to be proved wrong :)

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Reviewed.

Looks like the test cases are all passing and everything is marked.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Deprecate tracker module in Drupal 9.5 » Deprecate tracker module in Drupal 10.1.x
Version: 9.5.x-dev » 10.1.x-dev

Since Tracker missed the beta deadline, we will need to update the issue and meta to deprecate it in D10 for removal in D11 instead. Thanks!

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
smustgrave’s picture

smustgrave commented

So what needs to be done? The MR applies cleanly to D10.1

Spokje opened merge request !2773

Spokje closed merge request !2399

smustgrave’s picture

smustgrave commented

Ah thanks @Spokje

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

The MR passes 10.1.x still.

Moving back to RTBC for Drupal 10.

spokje’s picture

spokje
Primary language Dutch
commented

Updated CR and https://www.drupal.org/docs/core-modules-and-themes/deprecated-and-obsol... to mention 10.1.0 and 11.0

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 1b65dc6 and pushed to 10.1.x. Thanks!

  • alexpott committed 1b65dc6 on 10.1.x 
    Issue #3261679 by Spokje, naveenvalecha, quietone, smustgrave, xjm,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Spokje closed merge request !2773