[D8] Block warmer

Hi @prudloff,

Please implement hook_help.

I made a quick look and noticed that module contains a composer.lock file (which is very weird).
I'm also not sure of composer.json file, it has only dev dependency on some quality checker, so it doesn't have any impact on module functionality.
I think we should consider removing composer.* files from the application.

I didn't test the module manually because I'm not familiar with the Warmer module.

I think it would be best to ask @e0ipso or @slv_ to review the project since they're the maintainers of the original module. I would recommend creating a new task in Warmer issues queue and ask maintainers to review this task.

The composer.lock file should not be an issue.

Automated Review

I ran phpcs manually on the module (since pareview.sh is still broken). No issues/errors came out of this.

I did notice an open "@todo" in the BlockWarmer Plugin class for the function "buildIdsBatch()"

Manual Review

Individual user account

Follows the guidelines for individual user accounts.

No duplication

Does not cause module duplication and/or fragmentation.

Master Branch

Follows the guidelines for master branch.

Licensing

Follows the licensing requirements.

3rd party assets/code

Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Follows the guidelines for project length and complexity.

Secure code

Meets the security requirements.

This review uses the Project Application Review Template.

One small note, I see you commented on this issue https://www.drupal.org/project/warmer/issues/3118299 to mention that your contrib is created, however you placed the comment on a closed ticket. So most likely the maintainer did not see the comment and is not aware the module exists. Either re-open the ticket or create a new ticket to ask for your module to be listed on the main module page.

Thank you for your contribution! I am going to update the project to opt it into security coverage.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

It's enough you apply using a module that contains more code.