Problem/Motivation

Display of % makes tables x2 wider but 80% of time provides not useful information
Additionally to abbrevation of function name it could help view table on mobile screens

Steps to reproduce

Proposed resolution

- remove columns that disaplays % data
- embed as data-attribute on value cells to allow add effects with JS (color 10 most expensive, toggle display of value/%/human-readable)

Remaining tasks

- design, create patch, commit
- file follow-up for additional improvements

User interface changes

TBD

API changes

no

Data model changes

no

CommentFileSizeAuthor
#2 xhprof-percent-claro.png115.34 KBandypost
#2 xhprof-percent-seven.png129.72 KBandypost
#2 xhprof-percen-bartik.png219.2 KBandypost
#2 3167829-2.patch3.02 KBandypost
xhprof-percent.png49.03 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs work
StatusFileSize
new 3167829-2.patch3.02 KB
new xhprof-percen-bartik.png219.2 KB
new xhprof-percent-seven.png129.72 KB
new xhprof-percent-claro.png115.34 KB

Initial stub, looks percents could be calculated via js on demand

bartik

seven

claro

andypost’s picture

andypost
he/him
Primary language Russian
commented

Related https://tideways.com/profiler/blog/analyzing-xhprof-traces