[meta] Remove deprecated code flagged by @trigger_error messages for Drupal 9 compatibility

Thanks for this. You read my mind as I was about to do this - see #3033376: Add drupalci.yml test file to configure d.o. testing
I was planning to add a default drupalci.yml so when that is done I was going to make the change to run without hiding the deprecations.

The results above match my Travis test builds on
https://travis-ci.org/jonathan1055/scheduler/branches which is good.

By the way, the link in the issue summary does not work. I think you truncated the url.

No that #3034805: Using setPublished() with a $published parameter is deprecated in 8.3 the number of deprecation fails should be lower.

Fixed the link to Gábor Hojtsy's blog post.

Now that we have a default drupalci.yml added in #3033376-5: Add drupalci.yml test file to configure d.o. testing here is a patch which just adds the "suppress-deprecations: false" configuration option.

Had 5 fails before, but now that #3034986: Replace deprecated SafeMarkup::checkPlain() is in, I've requeued the patch in #10

Of course, the drupalci.yml file has been changed since that last patch.

That's good. We've removed the four deprecation fails from #3034986: Replace deprecated SafeMarkup::checkPlain() and now just have the one covered by
#3035911: EntityInterface::link() is deprecated, replace with EntityInterface::toLink()

Ha! No sooner had we removed the last deprecation via #3035911: EntityInterface::link() is deprecated, replace with EntityInterface::toLink() then Core deprecate something else (almost exactly at the same time). Luckily I had two days of clean test results on TravisCi as I pushed the checkPlain() fixed there earlier than to d.o.

I have raised #3038746: Remove deprecated EntityDefinitionUpdateManagerInterface::applyUpdates() from hook_install and hook_uninstall for the new deprecation.

Now that #3038746: Remove deprecated EntityDefinitionUpdateManagerInterface::applyUpdates() from hook_install and hook_uninstall is done, we should get clean tests with no deprecation warnings. Re-queueing patch #13

Setting this to RTBC (even though the patch is not intended to be committed) just to see if that causes the patch to be automatically re-tested periodically.

I re-ran the patch today and we had one failure, in DefaultTimeTest. The test failure is very likely to be due to #2957490: Default time tests fail in run-up to Daylight Saving clock change.

I've raised #3048600: Drupal::url() is deprecated, replace with \Drupal\Core\Url object for the latest failure.

Fixed #3048600: Drupal::url() is deprecated, replace with \Drupal\Core\Url object and now the tests are green and all passing with no @trigger_error warnings.

Renaming to make this issue more distinct from #3042677: Drupal 9 Deprecated Code Report for Scheduler

New deprecation #3059741: Replace deprecated entityManager() with entityTypeManager() which is now actually triggers a warning.

Using PHP 7.1, MySQL 5.7, D8.8 On 5th June - working fine. 6th June - we get

warning: drupalci.yml has type 100644, expected 100755
error: patch failed: drupalci.yml:25
error: drupalci.yml: patch does not apply

Here is the same patch but with index 9608ac7..b401dbf 100755 manually changed to index 9608ac7..b401dbf 100644

OK that fixed the 100755/100644 problem but that was not the main thing. The patch still fails because this change is already in the drupalci.yml file - I committed it in #3059741-3: Replace deprecated entityManager() with entityTypeManager()

So, there is no patch here on this issue now. We can keep it open as a Meta issue if that is useful. We will get alerted to any deprecation triggers via the daily automated testing.

Fixed #3086762: Change scheduler_api_test uid from entity_reference_autocomplete to number to avoid match_limit deprecation

I have reset the drupalci.yml config to suppress-deprecations: true as we do not really want the tests on drupal.org to be showing failures on the project front page whenever a new deprecation trigger is commited to core.

https://travis-ci.org/jonathan1055/scheduler is set to alert me with a failure for any use of deprecated code, and will create child issues here to fix them.

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.

For info on #3079913: Add new 'core_version_requirement' key to .info.yml I have just committed this which adds core_version_requirement to the two main module .info.yml files (not the test modules)

Adding parent. Not all deprecations are for D9 but most are.

Re-rolled patch #26 to show deprecations

Moving to the 2.x branch to assist with Drupal 10 preparation

Actually, this is all about Drupal 9 so marking this fixed.