The oembed URL used in this module is using http://soundcloud.com/oembed but needs to be updated to https://soundcloud.com/oembed. The response from soundcloudfield_curl_get() is returning an HTML redirection notice and causes the player to not work at all. The path needs to be updated to https://.

<html><body>You are being <a href="https://soundcloud.com/oembed?iframe=true&amp;url=<removed>">redirected</a>.</body></html>
CommentFileSizeAuthor
#3 soundcloud-oembed_https-3075203-2-D8.patch859 bytesjeffschuler
#2 soundcloudfield-3075203-1.patch1.03 KBvinmassaro

Comments

vinmassaro created an issue. See original summary.

vinmassaro’s picture

vinmassaro commented
Status: Active » Needs review
StatusFileSize
new soundcloudfield-3075203-1.patch1.03 KB
jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
StatusFileSize
new soundcloud-oembed_https-3075203-2-D8.patch859 bytes

Same thing for D8.

alisonb’s picture

alisonb commented

Thanks so much for this. I made the change to https manually on a D7 site and it worked perfectly.

vinmassaro’s picture

vinmassaro commented
Status: Needs review » Reviewed & tested by the community

Trivial change, moving to RTBC.

catalyst_red’s picture

catalyst_red commented

Thank you for sharing the fix!

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented

RTBC from me.

git apply -v soundcloud-oembed_https-3075203-2-D8.patch
Checking patch src/Plugin/Field/FieldFormatter/SoundCloudDefaultFormatter.php...
Hunk #1 succeeded at 178 (offset 5 lines).
Applied patch src/Plugin/Field/FieldFormatter/SoundCloudDefaultFormatter.php cleanly.
pingevt’s picture

pingevt commented

Worked for me as well

msypes’s picture

msypes commented

Works for me too!
Thanks.

chris matthews’s picture

chris matthews commented

Is there still a maintainer for the SoundCloud field module? The last commit on 8.x-1.x was in April 2017. It would be nice if the patch in #3 could be committed and pushed to a new release.

david.qdoscc’s picture

david.qdoscc commented

+1. This module is unusable without this one character patch. Please can someone commit it to save us all wasting time searching for the solution?

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented

Looks like an issue to discuss finding new project maintainers was just opened -- #3138560: Module co-maintainers -- (anyone?) and @Webbeh reached out to the current maintainer.

See also Dealing with unsupported (abandoned) projects.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented

Do not rush with such suggestions please. This project is not abandoned nor unsupported. MAROQQO digital media (the company I am CEO of) is willing to support the project development and has contacted Attila already. He is an awesome long-term contributor to the Drupal project and we offer co-maintainerchip regarding and alongside the new Drupal 8./9. contribution guideline initiative and automated deprecation patches etc.. So please have some more patience. The RTBC patches can be added quickly and if Attila agrees we can roll out Beta and final D8 release asap. But before that all patches need another review and we need to mark the project D9 ready.

This module is unusable without this one character patch.

Such comments are really not very useful nor do they add anything positive to the project. There is always a good reason for simple patches not to be added yet. So please let us respect the hard work already put into the projects and provide constructive and really helpful support.

bubu’s picture

bubu
Primary language Hungarian
Location Hungary
commented

Thanks for the patch #3. Works well.

benjarlett’s picture

benjarlett commented

doesnt work in combination with this patch (required for drupal 9) https://www.drupal.org/project/soundcloudfield/issues/3168341

  • vinmassaro authored 0cbf2b3 on 7.x-1.x 
    Issue #3075203 by vinmassaro, jeffschuler, diqidoq: Embed stopped...

  • jeffschuler authored 447694d on 8.x-1.x 
    Issue #3075203 by vinmassaro, jeffschuler, diqidoq: Embed stopped...
attila.fekete’s picture

attila.fekete commented
Status: Reviewed & tested by the community » Fixed

Thank you everyone, merged into 7.x and 8.x dev branches.
I apologize for being away so long.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.