Change record: The 'testing' install profile's setting of a default theme (Classy) is now deprecated.

Since this change shouldn’t break anything for lower Core versions (i.e., before 8.8, where this property was added), as there the property should just be ignored, I think we can already fix this. Therefore, I’m splitting this off from #3023170: Test for compatibility with Drupal 9.

CommentFileSizeAuthor
#2 3103570-2--tests_default_theme.patch3.52 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 3103570-2--tests_default_theme.patch3.52 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/tests/src/Functional/CacheabilityTest.php
@@ -76,8 +76,8 @@ public function testExecuteTasksAction() {
     Block::create([
-      'id' => 'classy_local_actions',
-      'theme' => 'classy',
+      'id' => 'stark_local_actions',
+      'theme' => 'stark',
       'weight' => -20,

It's only safe to add *if* you don't have to make any other changes. Exactly because the property is ignored on 8.7, it will still use classy and then this will cause fails.

The block stuff could maybe use $this->drupalCreateBlock() which uses the default theme, and possibly the xpath changes will work too on both 8.8 and 8.7.

Not sure if it's worth it though ;)

I added a test run against 8.7 that I expect will have some fails.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Closed (won't fix)

Ah, makes sense. Thanks a lot for pointing this out! This whole D9 upgrade would have been a lot more difficult without you keeping an eye on this issue queue. ;)
So, merging with the general D9 issue in #3023170: Test for compatibility with Drupal 9.