In #3079738-49: Add Claro administration theme to core, I noticed in point 25 that there were still work-arounds in place that were blocked on #3024975: Add Drupal JavaScript theme function for checkbox, which has since landed! 🥳

CommentFileSizeAuthor
#2 3085249-2.patch11.75 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 3085249-2.patch11.75 KB
huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented

This should be applied only if Drupal core version is 8.8.x.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

@huzooka in #3 is correct of course :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

@lauriii You could for now just include this in the script to build the core patch.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented

Also the scope of #3024975: Add Drupal JavaScript theme function for checkbox changed, and we need the whole field-item support (label + input + description) before we remove the media library override.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Oh! Can you link the other issue that is blocking this then? 🙏

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Related issues: +#3082598: Add theme function for form labels in JavaScript

This is the issue that is blocking us from removing the media library JS override: #3082598: Add theme function for form labels in JavaScript.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Remove work-arounds that were blocked on #3024975 » [PP-1] Remove work-arounds that were blocked on #3024975 and #3082598
Status: Needs review » Postponed
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

We could also move removing media_library/view: to a follow-up and remove the drupal.tableselect override here. Any thoughts?

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Related issues: +#3084724: Regression on table select checkbox
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Postponed » Closed (duplicate)

This seems like a duplicate to #3085249: [PP-1] Remove work-arounds that were blocked on #3024975 and #3082598.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Status: Closed (duplicate) » Postponed

@lauriii You just marked the issue duplicating itself.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Postponed » Closed (duplicate)

Sorry, I referenced wrong issue. This is the issue I was supposed to reference: #3024996: Remove tableselect.js and media_library.view.js overrides.