We can use getDisplayName instead of getUsername

CommentFileSizeAuthor
acl-21-1567461010.patch492 bytespifagor

Comments

pifagor created an issue. See original summary.

salvis’s picture

salvis
he/his
commented
Status: Needs review » Closed (duplicate)
Issue tags: +Bounty Hunter

You are wasting my time. I fixed this in #3082852: Replace deprecated getUsername() with getAccountName(). Most of your other recently created issues are already fixed, too.

You are welcome to contribute, but please fix the test in HEAD first, so that the testbot will run.

pifagor’s picture

pifagor commented

Dear @salvis

Thanks for the info.
Can I help with something? I will be happy to assist in the development of the module.

salvis’s picture

salvis
he/his
commented

Hi @pifagor,

If you could find a fix for #3081095: Project does not pass PHPUnit tests, that would be extremely helpful.

I don't know much about how the migration tests work, but apparently, there's some D6/D7 content that's set up by Core to help with testing contribs, so that contribs can concentrate on their own stuff. The actual test then involves migrating that content and check whether the additions of the contrib are coming along correctly.

AFAICS, the D7 nodes have attached files, and these aren't migrated, which causes the ACL test failure. I don't think this is an ACL problem, but just a bug in the test, but I haven't been able to find out how to fix it...