Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Support for off-canvas navbar and dropdown menus is currently hardcoded in code. This makes the implementation of client sites with very different navigation implementation difficult a bit difficult because you need to override a lot of CSS.
We should decouple off-canvas and dropdown support more so it can be disabled with current theme options.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | more-navbar-decoupling-3078120-8.patch | 36.27 KB | pivica |
| #8 | interdiff-3078120-7-8.txt | 1.82 KB | pivica |
Comments
Comment #2
pivica commentedHere is a first patch.
Comment #3
pivica commentedFixed string concatenation for dropdown-toggle case.
Comment #4
pivica commentedThe previous patch is introducing a nasty bug because in macro navbar_type is not defined, we need to pass it again as a variable.
Additionally, the refactoring and moving offcanvas CSS code to a new sass file exposed a new bug in drush generator - it is not handling this case correctly and leaving imports in previous SASS file which is producing duplicated CSS code now.
Moreover, a couple of smaller bugs in navbar JS code are fixed, due to extensive testing, and code is improved a bit.
Hopefully, all the problems are addressed with a new patch.
Comment #5
pivica commentedThe last patch is fine but it really has a wrong name, attaching a new one.
Comment #6
pivica commentedA New version that moves CSS needed for dropdown or horizontal to separate SASS partial so we can exclude these rules when navbar type option is off.
Comment #7
pivica commentedRenamed newly added partial _navbar-layout to _navbar-second-level.
Comment #8
pivica commentedLet's not render off-canvas close link when offcanvase type is off. Improved off-canvas type description info for off option.
Comment #10
pivica commentedFixed 'off canvas' spell error, committed.