See #2909372-14: Enable 'Drupal.Commenting.VariableComment.MissingVar' coding standard for the reason why this child issue was created and #2909364: [meta] Fix 'Drupal.Commenting.VariableComment' coding standard for general instructions about working on Drupal.Commenting.VariableComment coding standard errors.

CommentFileSizeAuthor
#10 interdiff-2924781-7-10.txt588 bytesyogeshmpawar
#10 2924781-10.patch10.91 KByogeshmpawar
#7 missing_var_annotation_for_scalars_no_default_value-2924781-7.diff11.13 KBosman
#5 missing_var_annotation_for_scalars_no_default_value-2924781-5.diff11.69 KBosman

Comments

zaporylie created an issue. See original summary.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

osman’s picture

osman
Location Copenhagen
commented
Status: Active » Needs review
StatusFileSize
new missing_var_annotation_for_scalars_no_default_value-2924781-5.diff11.69 KB
zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Status: Needs review » Needs work 
+++ b/core/phpcs.xml.dist
@@ -80,7 +80,6 @@
-    <exclude name="Drupal.Commenting.VariableComment.MissingVar"/>

This must be removed for now, it will be added in the parent issue once it's fixed.

osman’s picture

osman
Location Copenhagen
commented
Status: Needs work » Needs review
StatusFileSize
new missing_var_annotation_for_scalars_no_default_value-2924781-7.diff11.13 KB

trying again.

mfernea’s picture

mfernea commented
Status: Needs review » Needs work 
+++ b/core/modules/system/tests/src/Functional/Form/StateValuesCleanAdvancedTest.php
@@ -27,6 +27,8 @@ class StateValuesCleanAdvancedTest extends BrowserTestBase {
+   * @var string|false

Isn't it string|bool?

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: Unassigned » yogeshmpawar
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: yogeshmpawar » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2924781-10.patch10.91 KB
new interdiff-2924781-7-10.txt588 bytes

Comments addressed in #8 & added an interdiff as well.

mfernea’s picture

mfernea commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Issue tags: +DevDaysTransylvania

Tagging (and +1 to RTBC)

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 35ffd80 and pushed to 8.8.x. Thanks!

  • catch committed 35ffd80 on 8.8.x 
    Issue #2924781 by osman, yogeshmpawar, zaporylie, mfernea: Missing @var...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.