When adding an entity reference field for (FillPdf Form), the vale of each template is true but the label is empty. Please check the attached screenshot.

CommentFileSizeAuthor
Screen Shot 2018-12-26 at 11.27.34 AM.png36.19 KBanas_maw
#2 entity-reference-field-empty-label_3022485_2.patch1011 bytesanas_maw
#4 entity_reference_before.png2.62 KBpancho
#4 entity_reference_after.png5.48 KBpancho
#4 entity_reference_autocomplete_after.png4.62 KBpancho
#4 admin_title_before.png9.85 KBpancho
#4 admin_title_after.png8.52 KBpancho
#4 entity-reference-field-empty-label_3022485_4.patch7.41 KBpancho
#4 3022485_2-4_interdiff.txt6.94 KBpancho
#4 entity-reference-field-empty-label_3022485_4_test-only.patch3.82 KBpancho
#6 3022485_2-6_interdiff.txt7.48 KBpancho
#6 entity-reference-field-empty-label_3022485_6.patch8.03 KBpancho

Comments

Anas_maw created an issue. See original summary.

anas_maw’s picture

anas_maw commented
Status: Active » Needs review
StatusFileSize
new entity-reference-field-empty-label_3022485_2.patch1011 bytes

This patch fixes the issue by making the Administrative description as the label for the entity. Also, i make Administrative description field required.

anas_maw’s picture

anas_maw commented

Also, let me thank you for this great module. I really appreciate the efforts spent to made this great module.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
StatusFileSize
new entity_reference_before.png2.62 KB
new entity_reference_after.png5.48 KB
new entity_reference_autocomplete_after.png4.62 KB
new admin_title_before.png9.85 KB
new admin_title_after.png8.52 KB
new entity-reference-field-empty-label_3022485_4.patch7.41 KB
new 3022485_2-4_interdiff.txt6.94 KB
new entity-reference-field-empty-label_3022485_4_test-only.patch3.82 KB

@Anas_maw:
Thanks for your report and the enclosed patch!
Indeed, the admin_title column should be used as label, which is also needed in #3023341: Fix FillPdfFileContext label key; add FillPdfForm canonical route.

I'm a bit hesitant to mark 'admin_title' #required for now, and think we should revisit this decision in a separate issue #3040776: Autocreate 'admin_title' from metadata and mark it required.

However, in order to convey the increased relevance of the 'admin_title', I'm standardizing on calling it 'Administrative title' rather than 'Administrative description' (on the overview page it's already been identified as such) on the FillPdfForm edit form. Also I'm rewording the description, now suggesting the admin may better add an 'admin_title'.

Also, I'm adding a couple of tests to check whether the label is correctly set both in an entity reference select and a status message when updating the FillPdfForm entity.

Here are some screenshots:

Entity reference select before:
entity reference select before
After:
entity reference select after
Autocomplete after:
entity reference select after

And here's the admin_title field before:
admin_title setting before
and after:
admin_title setting after

Status: Needs review » Needs work

The last submitted patch, 4: entity-reference-field-empty-label_3022485_4_test-only.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Title: Entity reference field empty label » Undefined entity label impedes identifying FillPdfForm
Status: Needs work » Needs review
StatusFileSize
new entity-reference-field-empty-label_3022485_6.patch8.03 KB
new 3022485_2-6_interdiff.txt7.48 KB

Same, minus logger notices (scope creep), minus a handful of coding standards violations.

  • Pancho committed 0f1845f on 8.x-4.x 
    Issue #3022485 by Anas_maw, Pancho: Undefined entity label impedes...
pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Needs review » Fixed
Related issues: +#3023341: Fix FillPdfFileContext label key; add FillPdfForm canonical route, +#3040776: Autocreate 'admin_title' from metadata and mark it required

Again, thank you for filing this bug report and providing a patch!

Follow-ups:

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.