Module name should be capitalized per coding standards.

CommentFileSizeAuthor
#3 Screen Shot 2018-10-01 at 5.32.41 PM.png15.81 KBalonaoneill
#2 Update_dependencies_format_in_info.yml_3003434-2.patch469 byteschipway

Comments

chipway created an issue. See original summary.

chipway’s picture

chipway commented
Assigned: chipway » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Update_dependencies_format_in_info.yml_3003434-2.patch469 bytes

Here is the patch. Please review.

I also removed the unnecessary quotes.

alonaoneill’s picture

alonaoneill commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2018-10-01 at 5.32.41 PM.png15.81 KB

Code looks good, the name of the module is now capitalized on the Extend page. Screenshot provided."
The dependency namespacing aligns with Drupal documentation standards.
Marking as RTBC
Thank you for working on module!
P.S. Please change Issue Title!

manuel.adan’s picture

manuel.adan
Location 🌌
commented
Status: Reviewed & tested by the community » Needs work

The module name is present in many other locations, like PHP comments, labels and titles.

chipway’s picture

chipway commented

Here we are dealing only with .info.yml.

chipway’s picture

chipway commented
Status: Needs work » Needs review
alonaoneill’s picture

alonaoneill commented
Status: Needs review » Reviewed & tested by the community
manuel.adan’s picture

manuel.adan
Location 🌌
commented
Status: Reviewed & tested by the community » Needs work

@alonaoneill, could you please explain us why to you move this to RTBC? As previously mentioned, this issue will only be in RTBC when the module name is reviewed in all the places it appears.

alonaoneill’s picture

alonaoneill commented

This issues was open for info.yml file and it looks like issue in that file was fixed.

manuel.adan’s picture

manuel.adan
Location 🌌
commented

Thank's for the clarification. In order to save work, issues should be fixed by topic, not per file.

manuel.adan’s picture

manuel.adan
Location 🌌
commented
Status: Needs work » Closed (duplicate)
Related issues: +#3121516: Coding standards review