Closed (fixed)
Project:
Forward
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
10 May 2018 at 19:17 UTC
Updated:
3 Nov 2019 at 18:39 UTC
Jump to comment: Most recent, Most recent file
I almost called this a bug report. ;) Currently, my forward.settings.yml file in config is huge. It's full of entries for every possible entity on the system where forward is *not* enabled. Every time I do anything to the rest of the site, this config wants to add more (pointless) lines to itself. Why am I seeing all this noise?
forward_entity_redirect: false
forward_redirect_redirect: false
forward_entity_shortcut: false
forward_shortcut_default: false
forward_entity_taxonomy_term: false
forward_taxonomy_term_city: false
forward_taxonomy_term_contributors: false
forward_taxonomy_term_country: false
forward_taxonomy_term_credit: false
forward_taxonomy_term_image_gallery: false
forward_taxonomy_term_image_provider: false
...
Why not filter out everything that's false and only export settings where the line is true and forward cares?
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 2972096-11.forward-clean-config-8x-2x-backport.patch | 4.06 KB | dww |
| #6 | 2972096-6.forward-config-node-type-no-php-warning.patch | 1.5 KB | dww |
| #2 | 2972096-2.forward-clean-settings.patch | 2.8 KB | dww |
Comments
Comment #2
dwwTested and working nicely.
Happy to report this applies cleanly to the end of the current 8.x-2.x branch, and the hypothetical 8.x-3.x branch (which I have in a local cloned repo) with all the other patches applied. So this shouldn't conflict with anything (and should definitely be present in both branches, if we go forward with #2971849: Consider an 8.x-3.x branch.
Thoughts?
Thanks!
-Derek
Comment #3
john.oltman commentedComment #4
dwwI do think this is a good candidate for a backport. Same patch should apply.
Comment #5
dwwMaybe RTBC is a more appropriate status, but perhaps someone else should consider it first. Anyway, there's nothing to be ported. Same patch applies to both branches...
Comment #6
dwwFollow-up fix for 8.x-3.x branch: I didn't notice the place where we alter the node type form to inject a checkbox. That was triggering a PHP warning since it assumed there was a value in settings for every node type.
Comment #8
john.oltman commentedComment #10
dwwSince I want this on my 8.x-2.x sites, here's a re-roll backport for the 8.x-2.x branch after 8.x-2.2. Posting it here in case anyone else wants this behavior, and so composer.json has a nice URL to find the patch. ;)
Cheers,
-Derek
Comment #11
dwwSorry for the noise, doing too many things at once. I left a stray
}in here for a syntax error. This time I've actually tested the patch. ;)Comment #12
dww*sigh*. ;)
Comment #13
john.oltman commentedThanks I will apply this as soon as I can to 2.x branch, along with the backport of that other patch from the other issue. I am traveling so it might be a few days.
Comment #14
john.oltman commentedComment #15
john.oltman commentedComment #16
john.oltman commentedComment #17
dwwCool. #12 should apply cleanly and Just Work(tm). ;)
Cheers,
-Derek
Comment #18
john.oltman commentedThis was included in https://git.drupalcode.org/project/forward/commit/ad071373f08c52531bae72...
Comment #19
dwwLovely, thanks!