Looking at the code I noticed that there is room for improvement performance-wise. file_entity_entitycache_load() is not needed as it's job is done by file_entitycache_file_load(which is BTW wrongly named - it should be file_entity_entitycache_file_load. So I will provided a patch for that. The code has been added in https://www.drupal.org/project/file_entity/issues/2665960, check it for more info.

CommentFileSizeAuthor
#2 file_entity-performance_optimization-2966026-2-7.x.patch961 bytesangel.h

Comments

angel.h created an issue. See original summary.

angel.h’s picture

angel.h
Primary language English
Location Plovdiv
commented
Status: Needs work » Needs review
StatusFileSize
new file_entity-performance_optimization-2966026-2-7.x.patch961 bytes

Here is the patch.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Seems to make sense, did you get any performance statistics results before and after to share?

What performance gain might we expect?

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

I just tested your patch, it seems to work fine. I did not do any profiling on it though, I don't have a test environment with xhprof handy at the moment.

NOTE: for additional performance improvements, please try out this patch as well
#2642764-34: Speed up via shortcutting token file_entity_file_load

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#2963490: Slow performance on Home Page
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#2642764: Speed up via shortcutting token file_entity_file_load
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Title: Performance issue » Performance fix - rename file_entitycache_file_load to file_entity_entitycache_file_load
Issue tags: +Performance
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

I tested this patch quite a bit, cannot find anything wrong with it. Passes all tests too.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Fixed

pushed to 7.x-2.x and 7.x-3.x
thanks @Angel

please review the other performance patch if you can.
#2642764-34: Speed up via shortcutting token file_entity_file_load

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@Angel, did you actually do any performance profiling on this patch? before/after results?
would be nice to know, add some confidence.

angel.h’s picture

angel.h
Primary language English
Location Plovdiv
commented

@joseph.olstad Yes, I did but only locally and yes it did show improvement but I did not record it. Today or tomorrow I'll deploy on live and since I have a jMeter recording of before, I'll let you know about the after! Also - thanks for the quick reaction.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Hi Angel.h, if you can also performance profile the other patch also that'd be great.
would be nice to know how much of a change these two patches bring.
here's the other
#2642764-34: Speed up via shortcutting token file_entity_file_load

angel.h’s picture

angel.h
Primary language English
Location Plovdiv
commented
Assigned: angel.h » Unassigned

@joseph.olstad Just tested the before and after of https://www.drupal.org/files/issues/2018-04-28/file_entity-n2642764-34.p... on a very slow local site where the average load time on 3 pages was 19641 miliseconds and it went down to 13458 miliseconds - a gain of 6183 miliseconds!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Ok, this justifies cutting a release asap.

Thanks!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Ok, thanks, I just cut 7.x-2.21 and 7.x-3.0-beta7

If you can please help review the other pending performance patch, that'd be greatly appreciated.
#2642764-34: Speed up via shortcutting token file_entity_file_load

THANKS!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.