Referencing this issue in Media: #2473481: Clicking images in media browser doesn't select them. We encountered this issue in Open Atrium. I don't think it's directly reproducible in the current Panopoly theme and might be related to our Bootstrap or Radix based theme in OA. But the code in Media seems clearly wrong in this case.

Adding a patch to panopoly_widgets here so we can refer to it in the OA build script. Would be interested in having Panopoly test for any side effects of this patch. Thanks!

Comments

mpotter’s picture

Status: Active » Needs review
StatusFileSize
new773 bytes

Patch to panopoly_widgets is here.

mpotter’s picture

StatusFileSize
new772 bytes

Derp, typo fail!

mpotter’s picture

StatusFileSize
new878 bytes

Well shoot, this gets annoying with multiple patches. OA already applies a patch to panopoly_widgets for [media], so we need to combine them for this to work in OA. So here is a consolidated patch including #2458039: Allow multi select for media items.

This applies to the -dev version of panopoly_widgets, not the 1.20 release.

mpotter’s picture

StatusFileSize
new884 bytes

Patch updated for latest panopoly_widgets dev

mpotter’s picture

Issue tags: +openatrium2
mpotter’s picture

Issue tags: -openatrium2 +oa patches
mpotter’s picture

StatusFileSize
new1008 bytes

Looks like there was a further issue for Media Browser not loading it's javascript.

This new patch contains the updated list of Media patches for Panopoly used in Open Atrium:

#951004: Allow selecting of multiple media items for a multi value media field in the same dialog
#2473481: Clicking images in media browser doesn't select them
#2528428: Javascript not loaded when Media Browser view is empty

These should be added to Panopoly when they update the Media module to the latest version.

mpotter’s picture

StatusFileSize
new950 bytes

Here is the updated patch for latest Panopoly dev

mpotter’s picture

StatusFileSize
new950 bytes

Here is a better filename for the patch to mirror what we do in panopoly_core

mpotter’s picture

Title: Clicking images in My Library and My Files doesn't select them » Patches used in Open Atrium for Panopoly Widgets

Renaming this to something closer to what it's being used for now.

mpotter’s picture

mpotter’s picture

StatusFileSize
new950 bytes

That was fast. #2534724: Browser window opens twice for field image is committed, so here is the updated patch

mpotter’s picture

StatusFileSize
new1.04 KB

OK, and there is a commit from the media -dev branch that we also need here for multi-select. Documented in #2549809: Status of "Fixed media browser appearing once for each time a field is repeated on the same page."

mpotter’s picture

StatusFileSize
new1.09 KB

Sigh...forgot to re-roll that against latest panopoly_widget dev. Here it is again.

mpotter’s picture

StatusFileSize
new754 bytes

Updating patch for latest dev

mpotter’s picture

StatusFileSize
new754 bytes

And another fix

mpotter’s picture

StatusFileSize
new848 bytes

Updating patch to latest dev.

mpotter’s picture

StatusFileSize
new1.02 KB

Here is a temp patch that also updates Media to 2.0 pending this getting fixed in Panopoly Widgets directly.

mpotter’s picture

StatusFileSize
new915 bytes

Sigh...here is a version that applies to Panopoly 1.43 instead of dev (#18 is for dev)

mpotter’s picture

StatusFileSize
new698 bytes

This is for the latest dev

mpotter’s picture

StatusFileSize
new703 bytes

Re-roll for latest dev

joseph.olstad’s picture

joseph.olstad’s picture

joseph.olstad’s picture

StatusFileSize
new1.02 KB

Patch needed for file_entity
Please see:
#2932229-14: Unable to create or edit a Document Page in Section unless administrator

Here is the new panopoly_widgets patch.

joseph.olstad’s picture

Patch 24 above resolves a critical (imho) regression with the latest releases of openatrium.

mpotter’s picture

Please ignore the patch posted in #24. This issue thread is only for Media patches to Atrium/Panopoly. The patches for File Entity are in #2477397: Patches for file_entity from OpenAtrium.

The patch in #21 is still what Atrium is using for now.

mpotter’s picture

StatusFileSize
new583 bytes

Updated patch for just updating Media to 2.19 so Atrium doesn't need to wait on Panopoly release

mpotter’s picture

StatusFileSize
new699 bytes

Here is the next version to apply against Panopoly 1.53 to bring Media up to 2.19.

mpotter’s picture

Latest panopoly dev updates to media 2.19 so this patch no longer needed in Atrium.