When you are viewing a help topic, you have tabs saying View, Edit, Translate (translate is only visible if you have a multilingual site).

We should also have a Delete tab, as you can see on pages like node/1.

Should just be a few lines in config_help.links.task.yml but also needs tests.

CommentFileSizeAuthor
#7 delete-tab.png28.3 KBandypost
#6 2921014-6.patch1.94 KBandypost
#2 2921014-2.patch1.95 KBandypost

Comments

jhodgdon created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 2921014-2.patch1.95 KB

Kind of that works for me

I'm using translation test to extend because it has additional tab

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work 
+++ b/tests/src/Functional/HelpTopicTranslateTest.php
@@ -60,7 +61,7 @@ class HelpTopicTranslateTest extends BrowserTestBase {
-  public function testHelpTranslation() {
+  public function _testHelpTranslation() {

I don't think this change should be in the patch. :)

Other than that, looks good. I haven't tested manually to see that it looks good.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Actually I think the test should go in HelpTopicAdminTest probably? We should verify the links actually work.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Related issues: +#2920309: Add experimental module for Help Topics
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new 2921014-6.patch1.94 KB

Moved test & added clicking on links

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
StatusFileSize
new delete-tab.png28.3 KB
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Fixed

Looks good! Committed to Sandbox and will update the Core patch shortly.

  • jhodgdon committed ed46a62 on 8.x-1.x authored by andypost 
    Issue #2921014 by andypost: Add a Delete tab to View/Edit/Translate

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.