If #2358923: Config translation module cannot deal with different base path ever gets fixed, we need to update the Configurable Help module to use it.

Currently, the Edit route is the base route for translations, which makes the tabs on configurable help topics be Edit / View / Translate. If that issue gets fixed, it should be possible to reverse that and make the View route be the base route, so the tab order can be View / Edit / Translate, which is more standard for other things like Nodes and etc.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

Title: Change » Change order of tabs to View / Edit / Translate
jhodgdon’s picture

Status: Postponed (maintainer needs more info) » Postponed

wrong status

jhodgdon’s picture

andypost’s picture

Status: Postponed » Needs review
FileSize
535 bytes

This no longer depends on issue in IS

andypost’s picture

FileSize
535 bytes

Proper patch, sorry

Tested it and "Translate" tab still not displayed also Delete have no tab to Edit

andypost’s picture

Possible workaround is move edit/delete & locking to entity canonical patch. I will try to explore that

jhodgdon’s picture

To get the Translate tab to display, you need to have all 4 multilingual modules enabled. Well, probably you don't need Content Translation, just Config Translation and the Language and Locale modules. Plus you have to have more than one language installed.

There's also a Translate test in the Functional subdirectory if you didn't see that.

Anyway, I think the other Core issue is still relevant probably. I don't think you can have anything but Edit be the base route for purposes of translations... but see if you can get it working.

And yeah we should add a Delete tab. Nodes have one. Maybe we should make that a separate issue though?
#2921014: Add a Delete tab to View/Edit/Translate

jhodgdon’s picture

What I recall from before is that if you don't make the config_help.links.task.yml have the edit form be the base route for the tabs, then the Translate tab doesn't work -- this is added by the Config Translate module and it assumes that the edit form is the base route for the tabs. That's half of #2358923: Config translation module cannot deal with different base path. There was also another problem, not relevant to this issue exactly.

So I don't think you can just switch it in the links.task.yml file.

jhodgdon’s picture

jhodgdon’s picture

Just a question... I noticed on #2921014: Add a Delete tab to View/Edit/Translate that a weight was added to the Delete tab. Is it possible to use weights to make the route that is technically the base for tabs not be on the left side? I haven't tried it but noting it here since it is maybe possible and would sidestep the Core problem about Edit not always being the basis for translation route groups.

andypost’s picture

Issue summary: View changes
FileSize
373 bytes
22.73 KB

Nice idea, that makes order valid, "Edit" gets 0 as defailt

jhodgdon’s picture

Status: Needs review » Fixed

Woot! Excellent. Thanks for the patch. Committed to Sandbox and about to actually roll a new Core patch with the last 5 fixes. I can barely keep up with you today. :)

  • jhodgdon committed 0af6096 on 8.x-1.x
    Issue #2372585 by andypost, jhodgdon: Change order of tabs to View /...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.