Closed (outdated)
Project:
Drupal core
Version:
10.1.x-dev
Component:
other
Priority:
Minor
Category:
Feature request
Assigned:
Reporter:
Created:
15 Apr 2013 at 09:55 UTC
Updated:
14 Jan 2023 at 19:36 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
vijaycs85Comment #2
vijaycs85Comment #3
vijaycs85.
Comment #4
vijaycs85Adding patch...
Comment #6
vijaycs857 failes related to contact - #2020867: Update contact module URL in test cases. - Fixed in this patch
3 fail related to views label- #2020859-1: Change the occurance of 'human_name' to 'label' in views configuration & schema - Needs fix in views schema, can't help in this patch
6 - will be fixed, if 3 in views fixed.
2 warnings - needs investigation.
Comment #8
vijaycs85updated
Comment #9
amateescu commentedLemme try out a patch here real quick :)
Comment #10
vijaycs85sure @amateescu, we can use this as a shared test environment :)
Comment #12
vijaycs85Comment #14
tayzlor commentedtesting out a patch real quick
Comment #16
vijaycs85.
Comment #17
vijaycs85.
Comment #18
vijaycs85.
Comment #19
vijaycs85Comment #20
vijaycs85Comment #22
vijaycs85.
Comment #23
vijaycs85Comment #24
vijaycs85Comment #25
vijaycs85Comment #26
vijaycs85.
Comment #27
vijaycs85Comment #29
vijaycs85Comment #30
vijaycs85Comment #31
vijaycs85Comment #32
vijaycs85Adding new test patch
Comment #33
vijaycs85.
Comment #35
vijaycs85Updating as per #33
Comment #37
vijaycs85Comment #38
vijaycs85updating info file...
Comment #39
vijaycs85this is not necessary.
this version update doesn't work.
Comment #41
vijaycs85ok here is an update for #39
Comment #42
vijaycs85nice wording...
Comment #44
vijaycs85Initial patch...
Comment #46
vijaycs85this need to be updated.
this change isn't necessary.
no need for an empty line here.
Comment #47
vijaycs85Thanks for the review. Here is an update.
#46.1 - FIXED, added more text
#46.2 - FIXED, reverted the change.
#46.3 - FIXED, reverted the change.
Comment #48
vijaycs85Comment #50
vijaycs85Comment #52
vijaycs85.
Comment #53
vijaycs85Comment #54
vijaycs85Comment #56
vijaycs85Comment #58
vijaycs85Comment #60
vijaycs85Comment #63
vijaycs85Comment #66
vijaycs85Comment #67
vijaycs85Comment #69
vijaycs85Comment #70
vijaycs85Comment #71
vijaycs85Comment #73
frob@vinjaycs85, thanks for your help on the book module view integration. I will manually test your patch on Monday.
As far as the patch goes, is there an interdiff? I don't know what is different between this patch and the last. I was thinking that all that would change is the test case so it should all be good right?
Comment #74
frobtesting a patch, do you mind if I use your test issue?
Comment #77
vijaycs85Comment #78
vijaycs85@frob:
reg #73: yeah, it's just removal of the duplicate code and added in trait.
reg #74: Feel free :)
Comment #79
vijaycs85Comment #80
vijaycs85Comment #81
vijaycs85Comment #83
vijaycs85Comment #84
David_Rothstein commentedTrying something out here (may turn out to be a false alarm)...
Comment #95
David_Rothstein commentedA couple more tests for the above.
Comment #98
vijaycs85Comment #100
vijaycs85Comment #102
vijaycs85Comment #104
vijaycs85Comment #106
vijaycs85Comment #108
vijaycs85Comment #111
vijaycs85Comment #113
swentel commentedComment #114
tim.plunkettA real test would be that change plus reverting http://cgit.drupalcode.org/ds/commit/?h=8.x-3.x&id=840dd04df9bfcb7eb4939...
Comment #115
swentel commentedIf I revert that commit in DS, the template_preprocess_layout() is not called. But the template is switched :)
Comment #117
vijaycs85DEMO patch... please don't mind....
Comment #118
vijaycs85you need to have testing as well?
Comment #119
vijaycs85Comment #120
vijaycs85thanks for reviewing @vijaycs85. here is an update as advised.
Comment #121
vijaycs85TESTING REVIEW AGAIN!
aasdfas
asdfa adfasdf
adsfa
Comment #123
vijaycs85Comment #124
vijaycs85Comment #127
vijaycs85Comment #129
vijaycs85Comment #130
vijaycs85Comment #133
vijaycs85Comment #135
vijaycs85Comment #137
David_Rothstein commentedUsing a no-op patch to check the current status of PostgreSQL and SQLite tests on Drupal 7.
Comment #138
vijaycs85Comment #139
vijaycs85Comment #141
vijaycs85Comment #143
vijaycs85Comment #144
vijaycs85Comment #146
vijaycs85Comment #148
vijaycs85.
Comment #151
David_Rothstein commentedQuick test to see if default PHP 7 patch testing is working on Drupal 7.
Comment #152
vijaycs85Comment #153
vijaycs85Comment #155
vijaycs85Comment #156
vijaycs85Comment #158
vijaycs85Comment #160
vijaycs85Comment #162
vijaycs85Comment #164
vijaycs85Comment #167
vijaycs85Comment #169
bnjmnmComment #171
vijaycs85Comment #173
vijaycs85Comment #174
vijaycs85.
Comment #182
smustgrave commentedcleaning up the review queue and this has been stale for 3 years so closing out for now.