Hi guys,

Not sure if this is something that was defined by design, but personally, after reading the documentation, README.TXT, labels and help texts, I was very surprised and confused to find out the global/default configuration I had set for my Views would be ignored....
which seems to be very different from how things are working for the nodes, for example...

Testing steps:

  1. Enable the metatag and views modules.
  2. Create a view with a description (so view:description isn't empty)
  3. Check the view's page for the Meta Tag description

The description tag is missing, along with any other configured Meta Tags.

Unfortunately, Views global/default Meta Tag's configuration is ignored even if it is overridden (in the default settings and not in the view itself - per view Meta Tag settings work properly).

Logically speaking, along the same lines of what's done for the other objects configurations, I suppose if a view's meta tag configuration wasn't set in the view itself, the Meta Tags should display on the views page according to the global/default configuration.

Feel free to let me know if you would have any comments, questions, issues, suggestions, objections or ideas on this bug report, I would certainly be glad to provide more information.
Thanks very much in advance for everyone's testing/reporting, reviews and comments.

CommentFileSizeAuthor
#2 metatag-views-default-config-ignored-2728929-2.patch812 bytesdydave

Comments

DYdave created an issue. See original summary.

dydave’s picture

dydave commented
Status: Active » Needs review
StatusFileSize
new metatag-views-default-config-ignored-2728929-2.patch812 bytes

Quick follow-up on this issue:

Please find attached to this comment a patch against metatag-7.x-1.x at 6d2d9bb, which allows falling back on Views Meta Tag default configuration if it is not overridden in the view.
File attached as: metatag-views-default-config-ignored-2728929-2.patch.

In this patch, the function metatag_config_load_with_defaults was used to try to aggregate all default settings, including Global ones.

If the settings were not overridden on a per-view basis, the default/global configuration is used to display Meta Tags on the Views page.

Feel free to let me know if you would have any comments, questions, issues, suggestions, objections or ideas on the attached patch, I would certainly be glad to provide more information.
Thanks very much in advance for everyone's testing/reporting, reviews and comments.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #2495941: Verify that Metatag:Views works correct w APIs, default configs »
Related issues: +#2495941: Verify that Metatag:Views works correct w APIs, default configs

Looking through the code of all three submodules some more, all three need work.

I need to ruminate on these, decide how they should work and then update all three accordingly. Yes, this patch will help, but we need to confirm the best place to trigger it for all three.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Postponed

This depends upon #2495941: Verify that Metatag:Views works correct w APIs, default configs, so I'm postponing it for now.

malcolm_p’s picture

malcolm_p commented

This patch is working for me.

Given that this issue was postponed on re-architecture decisions 4 years ago, it'd be great to see this make into a release to at least address the issue. If there are updates to the architecture of these sub-modules at a later date a change can be made then.