Provide views support for activity

1. +++ b/modules/crm_core_activity/src/ActivityViewsData.php
   @@ -0,0 +1,109 @@
   +    // View, Edit and Delete links of activity.
   +    $data['crm_core_activity']['view_crm_activity'] = array(
   +      'field' => array(
   +        'title' => t('Link'),
   +        'help' => t('Provide a simple link to the activity.'),
   +      ),
   +    );
   +
   +    $data['crm_core_activity']['edit_crm_activity'] = array(
   +      'field' => array(
   +        'title' => t('Edit link'),
   +        'help' => t('Provide a simple link to edit the activity.'),
   +      ),
   +    );
   +    $data['crm_core_activity']['delete_crm_activity'] = array(
   +      'field' => array(
   +        'title' => t('Delete link'),
   +        'help' => t('Provide a simple link to delete the activity.'),
   +      ),
   +    );
   

   This 3 fields don't make sense any more as we removed their handlers (since core provides same functionality in a different way).

2. +++ b/modules/crm_core_activity/src/ActivityViewsData.php
   @@ -0,0 +1,109 @@
   +    // Expose the creator uid.
   +    $data['crm_core_activity']['uid'] = array(
   +      'title' => t('Author'),
   +      'help' => t('Relate CRM Core Activities to the user who created it.'),
   +      'field' => array(
   +        'id' => 'numeric',
   +        'click sortable' => TRUE,
   +      ),
   +      'argument' => array(
   +        'id' => 'numeric',
   +      ),
   +      'filter' => array(
   +        'id' => 'numeric',
   +      ),
   +      'sort' => array(
   +        'id' => 'standard',
   +      ),
   +      'relationship' => array(
   +        'id' => 'standard',
   +        'label' => t('Author'),
   +        'base' => 'users',
   +        'base field' => 'uid',
   +      ),
   +    );
   

   This field is also provided by core.

3. +++ b/modules/crm_core_activity/src/ActivityViewsData.php
   @@ -0,0 +1,109 @@
   +    // Integration with Drupal search index.
   +    $data['search_index']['table']['join']['crm_core_activity'] = array(
   +      'left_field' => 'activity_id ',
   +      'field' => 'sid',
   +    );
   +
   +    $data['search_total']['table']['join']['crm_core_activity'] = array(
   +      'left_table' => 'search_index',
   +      'left_field' => 'word',
   +      'field' => 'word',
   +    );
   +
   +    $data['search_dataset']['table']['join']['crm_core_activity'] = array(
   +      'left_table' => 'search_index',
   +      'left_field' => 'sid',
   +      'field' => 'sid',
   +      'extra' => 'search_index.type = search_dataset.type',
   +      'type' => 'INNER',
   +    );
   

   We won't be using core search.

4. +++ b/modules/crm_core_activity/src/ActivityViewsData.php
   @@ -0,0 +1,109 @@
   +    $data['crm_core_activity_type']['table']['join'] = array(
   +      'crm_core_activity' => array(
   +        'left_field' => 'type',
   +        'field' => 'type',
   +      ),
   +    );
   +
   +    $data['crm_core_activity_type']['activity_string'] = array(
   +      'field' => array(
   +        'title' => t('Activity string'),
   +        'help' => t('Text describing the relationship between the contact and this activity.'),
   +        'id' => 'standard',
   +      ),
   +    );
   

   And types are not in SQL any more so we can't join.

5. +++ b/modules/crm_core_activity/src/Entity/Activity.php
   @@ -29,6 +29,7 @@ use Drupal\crm_core_contact\ContactInterface;
   + *     "views_data" = "Drupal\crm_core_activity\ActivityViewsData",
   

   Comments above make ActivityViewsData unneeded so we use EntityViewsData here instead.

   At the end of this comment block there is a @todo which can be removed with this patch.

6. +++ b/tests/modules/crm_core_tests/crm_core_tests.info.yml
   @@ -0,0 +1,9 @@
   +  - crm_core
   

   This module should depend on crm_core_activity too.

Committed. Thanks!