when trying to save something like 111111111111111 its being converted to 1.1111111111111E+14 in range_field_presave, use number format instead

CommentFileSizeAuthor
#3 range-change_roud_to_numbeer_format-2693493-1.patch1.31 KBanas_maw
#2 range-change_roud_to_numbeer_format-2693493-1.patch1.31 KBjosebc

Comments

josebc created an issue. See original summary.

josebc’s picture

josebc commented
Assigned: josebc » Unassigned
Status: Active » Needs review
StatusFileSize
new range-change_roud_to_numbeer_format-2693493-1.patch1.31 KB

patch file

anas_maw’s picture

anas_maw commented
StatusFileSize
new range-change_roud_to_numbeer_format-2693493-1.patch1.31 KB

This patch for 7.x-1.1 version

Status: Needs review » Needs work

The last submitted patch, 3: range-change_roud_to_numbeer_format-2693493-1.patch, failed testing.

The last submitted patch, 3: range-change_roud_to_numbeer_format-2693493-1.patch, failed testing.

The last submitted patch, 3: range-change_roud_to_numbeer_format-2693493-1.patch, failed testing.

The last submitted patch, 3: range-change_roud_to_numbeer_format-2693493-1.patch, failed testing.

anas_maw’s picture

anas_maw commented

  • Taran2L committed 1b84b93 on 7.x-1.x authored by Anas_maw 
    Issue #2693493 by josebc, Anas_maw: PHP round causing unexpexted...
taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented

Patch looks good to me.

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Needs work » Fixed
josebc’s picture

josebc commented

Hello

I think you didn't notice but you applied the wrong patch

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented

Hi josebc,

Patches are identical actually in terms of functionality.

I've applied your patch, but missed the correct radio button when I was generating commit message. Sadly, Drupal infrastructure doesn't allow for amending git history. Sorry for that.

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented

I think I can revert commit and create a new one with your authorship. Does this work for you?

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented

Btw, the same issue exists in core Number field for both D7 and D8.

  • Taran2L committed 2ded2b8 on 7.x-1.x 
    Revert "Issue #2693493 by josebc, Anas_maw: PHP round causing unexpexted...
taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented

Ah, patch breaks existing functionality! Reverted.

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Fixed » Needs work
josebc’s picture

josebc commented

Its ok, its just that the other patch was the same as the first one expect that the second was rerolled to apply against an old version which is wrong
No worries for the attribution what matters is that the issue is resolved

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Needs work » Closed (outdated)

this actually should be fixed by an updated validation in the version 1.8