I should have caught this in October, but it all happened a bit fast.

On the Extend page /admin/modules

This module is described as:

Inline Form Errors > Enables inline form errors.

But that says nothing about the advantages of enabling this module.

Screen shot of page.

I'd prefer something like:

Enabling inline form errors improves accessibility of web forms errors so that they meet WCAG 2.0 requirements.

CommentFileSizeAuthor
#12 Screen Shot 2016-03-07 at 6.38.48 PM.png138.75 KBRavindraSingh
#10 inline_form_error_mod_desc-2644818-10.patch660 bytesanishnirmal
#10 after patch.JPG43.82 KBanishnirmal
#6 Screen Shot 2016-01-12 at 9.12.40 PM.png79.63 KBmgifford
#4 Drupal_core-inline_form_errors_desc-2644818-4.patch913 bytesnupur.lohokare
Screen Shot 2016-01-05 at 5.20.38 PM.png38.67 KBmgifford

Comments

mgifford created an issue. See original summary.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Related issues: +#2578561: Move "Inline Form Errors" functionality to optional module and restore D7-style form errors by default
nupur.lohokare’s picture

nupur.lohokare commented
Assigned: Unassigned » nupur.lohokare
nupur.lohokare’s picture

nupur.lohokare commented
StatusFileSize
new Drupal_core-inline_form_errors_desc-2644818-4.patch913 bytes

Found the module description mentioned, and changed the description as per your suggestion.
Please review.

Thanks,
Nupur

nupur.lohokare’s picture

nupur.lohokare commented
Assigned: nupur.lohokare » Unassigned
Status: Active » Needs review
mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2016-01-12 at 9.12.40 PM.png79.63 KB

Simple text addition. I think this is good to go.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

One issue is that the module breaks things at the moment. I think we need a module that works better before having such a tantalising description. Reading that why wouldn't you enable it?

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

I suppose we could outline the outstanding problems with enabling the module.

Ultimately though, if they enable it, and it causes problems it can just be disabled. The question is if we should build in more of a warning.

Maybe something like:
'Enabling inline form errors improves accessibility of web forms errors so that they meet WCAG 2.0 requirements. Unfortunately, some functionality within Forms API may not work as desired. '

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

anishnirmal’s picture

anishnirmal commented
Status: Needs work » Needs review
StatusFileSize
new after patch.JPG43.82 KB
new inline_form_error_mod_desc-2644818-10.patch660 bytes

Hi,
Module description has been changed as per the suggestion at #8. Please review

After Patch
after patch

girish-jerk’s picture

girish-jerk commented
Assigned: Unassigned » girish-jerk
RavindraSingh’s picture

RavindraSingh commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2016-03-07 at 6.38.48 PM.png138.75 KB

Patch is validated and fixed, Steps to tests:

  • Download the patch from #10
  • Apply
  • Go to admin/modules and fill 'inline' in search modules box
  • you see the updated description added at in screenshot Inline form errors

Moving to RTBC.

anishnirmal’s picture

anishnirmal commented
Assigned: girish-jerk » Unassigned

  • catch committed 411a517 on 8.2.x 
    Issue #2644818 by Anishnirmal, nupur.lohokare: Inline Form Errors Module...

  • catch committed 3d1e387 on 8.1.x 
    Issue #2644818 by Anishnirmal, nupur.lohokare: Inline Form Errors Module...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.