Pre-configured settings.php with uninstalled Drupal causes the installer to refuse to move forward

Unassigning as this has been dormant for about a year. The issue is still alive and kicking.

The latest patch (using a service) container still needs some work.

The first problem I encountered (running a set-up with settings.php preconfigured) was that it could not find the `install_check` service. This is because the installer doesn't load the entire container from the services.yml file but uses a stripped down version in `install_begin_request` of `install.core.inc`. Adding the following snipped within the guard of `if ($install_state['settings_verified']) {` before the call to `drupal_is_installed()` fixed that first issue.

    $install_check_definition = new Definition();
    $install_check_definition
      ->setFactory('Drupal\Core\Site\InstallCheck\DatabaseInstallCheck::create')
      ->addArgument(new Reference('service_container'));
    $definitions = array('install_check' => $install_check_definition);
    $container->addDefinitions($definitions);

This snippet uses the a custom definition because I couldn't find a shorthand to add a factory to the container. I'm unsure why this classes uses a factory in the first place. It feels like we only ever need one instance of this service but I'm trying to keep changes minimal as my experience with Drupal 8 is limited.

The following problem we have is that the database service isn't registered. I'm not entirely sure how to fix that. The if statement in `install_begin_request` ensures the database is ready so it would be possible to register the needed service to the container. But this feels like the install method is growing quickly for a relatively simple check so I'm not entirely sure if that's the correct path forward.

Hi @Kingdutch,

Seems it has been fixed for me in 8.3.x did you also test it with the new release candidate?

Kind regards,
Lennard

Hey @Lennard,

Yes it seems to have been fixed in 3.0-rc2 : )

Removed another patch to make it work. A non installed site now redirects from index to install. Select a language and the installer starts. That's great!

Looks like the the first patch was partially implemented (the drupal_is_installed function can't be found but the check in the installer is present).

Marking this RTBC because I'm not sure if this still needs some kind of Change Record or can just be marked as fixed. I'll leave that to a maintainer :)

Now off to tackle the next error I encounter (unrelated to this issue).

This was fixed by #728702: Visiting index.php should redirect to install.php if settings.php already has database credentials but database is empty. which landed in 8.3.x - and has a CR https://www.drupal.org/node/2797353

If I'm wrong - please comment and I'll re-open the issue. I'm not sure a specific CR is necessary - this just works now - at long last.