Move system icons.theme.css, messages.theme.css, and progress.theme.css to Classy

i remember getting heavy pushback on moving icons a bout a year ago - gonna ping wimleers about it, so i can figure out what the issue was

Here's an attempt at messages.theme.css.

All the below steps in the test are ok. Attaching a screenshot where the CSS file is being loaded.

@Cottser The patch in #3 is getting rejected.

Thanks @rudraram, rebased and here is a new patch.

This works as expected in Classy, Bartik, and Seven.

The issue title and patch work do not match. The patch only contains work for messages.theme.css, are we not doing the rest in this issue? Halp :-)

new patch repeats the effort from #6, but duplicates it across progress, messages and icons.

Icons stylesheet is not treated as a library, but rather is a part of the base library. Progress and messages are treated as libraries, and only loaded when the twig templates are loaded.

comments?

This is looking good. I applied the patch and checked to make sure the files were still loading on the pages they should be, including the installation screen.

The only last thing concerning me is that the Classy files are loading after the sub-theme, meaning that they would overwrite any sub-theme CSS that conflicts. Is there an issue about this general problem with base themes?

In #2549563: Move system action-links.theme.css, breadcrumb.theme.css, and button.theme.css to Classy, it looks like they've solved the problem by keeping the weight: -10 value for the file. I think we could also do that here.

Updated #12 patch to lower weights

Sorry! Turns out that wasn't the solution:

+++ b/core/themes/classy/classy.libraries.yml
@@ -16,12 +17,24 @@ drupal.comment.threaded:
+    theme:
+      css/components/progress.css: { weight: -10 }

We need to change 'theme' to 'component'

Latest re-roll, changes theme elements to components.

css order on latest patch (please confirm)

I can confirm that the CSS loading order is now correct. Thank you! *RTBC wand*

No longer applies due to #2553465: Move system exposed-filters.theme.css, more-link.theme.css, and pager.theme.css to Classy.

In fact, these are all going to step all over each other, so should we maybe do all of the moving in one patch?

rrrrrrrrrerollin'

Reroll of #17. Fixed conflicts in:

• core/modules/system/system.libraries.yml
• core/themes/classy/classy.libraries.yml

Thanks! Looking good.

Postponed on: #2566597: [Mega patch] Move system *.theme.css files to Classy

The mega was committed so we don't need this.