Closed (fixed)
Project:
Font Awesome Iconpicker
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Reporter:
Created:
4 Aug 2015 at 12:05 UTC
Updated:
2 Oct 2015 at 17:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
d34dman commentedI have not tested it with Icon API. I would be interested in providing support if required. But i think its Icon API that would need to use this module.
Comment #2
pedrospI was using icon API so far to choose an icon, but there was a poor UI (no icon preview). I welcome this module precisely because of this fix.
Icon API provide his own field type "icon" and widget "icon", but this module use a "font awesome picker" widget that you can use on a standard textfield.
So for now it is one or another.
Data differences on database:
Icon API:
VARCHAR 64 field_example_bundle: fontawesome
VARCHAR 64 field_example_icon: empire
Fontawesome picker:
VARCHAR 255 field_example_pick_value: fa-empire
VARCHAR 255 field_example_pick_format: NULL
Comment #3
d34dman commentedI had a quick look at Icon API module. I will upload a patch shortly for testing.
Comment #4
d34dman commentedThe provided patch would expose "Font Awesome iconpicker" for icon_api fields. Be known that this widget only work with one provider (fontawesome). Please test and provide feedback.
Comment #5
pedrospThe patch expose the widget on an icon field, and you can pick and choose an icon. No saving/updating errors apparently.
However, it doesn't expose a previous value (a font awesome one), and it doesn't save anything on the database.
Thanks.
Comment #7
d34dman commentedPlease check the latest development snapshot. Should support icon api fields now.
Comment #8
pmusaraj commentedAttached is an updated patch against dev, that should fix the issues noted in comment #7. It's not entirely great though, because I can't seem to figure out how to reset the field altogether (it keeps 'fa-' if emptied).
Comment #9
pianomansam commentedI can verify that patch in #8 fixes this issue for me.
Comment #10
d34dman commented@pmusaraj what issue does patchi n #8 solve? How could i test it?
Comment #11
pmusaraj commented@D34dMan it fixes the issue mentioned by pedrosp in #5. Without the patch, the iconapi field doesn't maintain the stored value. With the patch, it does.
Comment #13
d34dman commentedThanks for the patch, it does work as desired. I did a small coding style fix and committed it under your name pmusaraj. Closing this issue as integration is now live.
Please create a new issue to address any enhancements. Especially i feel the prefix "fa-" should be kept as is, since it would be possible to enter some other classes in the future. However this has to be discussed in a separate thread and agreed upon.