Needs review
Project:
Patterns
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Jul 2010 at 12:46 UTC
Updated:
5 Jul 2010 at 12:46 UTC
The blocks configuration pattern code is supposed to support custom module names via the module tag. Moreover, it should be possible to set the block id (e.g. user-3) and have the block pattern code automatically set the module (to user in this case).
This wasn't working properly. The module was being set to 'block' even when the block id was specified. The attached patch fixes this:
--- ...\block.inc-revBASE.svn000.tmp.inc 2010-07-05 13:45:18.000000000 +-0100
+++ ...\sites\all\modules\patterns\components\block.inc 2010-07-05 13:34:44.000000000 +-0100
@@ -41,18 +41,20 @@
}
if (!empty($data['delete']) && empty($data['info']) && $data['module'] == 'block') {
$data['info'] = db_result(db_query('SELECT info FROM {boxes} WHERE bid = "%d"', $data['delta']));
}
+
if (!empty($data['pages']) && is_array($data['pages'])) {
$pages = implode("\r\n", $data['pages']);
$data['pages'] = str_replace('[front]', '<front>', $pages);
}
- if ( !(!empty($data['module']) && !empty($data['delta']) && !empty($data['info'])) ) {
+ // ##! Patch to allow for modules other than 'block'
+ if ( !(!empty($data['module']) && !empty($data['delta'])) ) {
$data['module'] = 'block';
}
break;
// Pre validate actions
case 'pre-validate':
| Comment | File | Size | Author |
|---|---|---|---|
| block.inc_.patch | 979 bytes | hiddentao |