Closed (fixed)
Project:
Drush
Component:
Make
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
18 Dec 2011 at 23:40 UTC
Updated:
14 Jan 2012 at 19:50 UTC
since the drupal repositories are all in git now, it would be nice if the download type, if not set, would default to "git" in the case where a download revision is specified. that way, instead of this:
project[views][version] = 2.x-dev
project[views][download][type] = "git"
project[views][download][revision] = "a6s5d4f6a5s4"
you could do this:
project[views][version] = 2.x-dev
project[views][download][revision] = "a6s5d4f6a5s4"
given that as part of http://drupal.org/node/779440, we'd like to encourage distro maintainers to use specific hashes in the case where they are using a development branch in their distro, this change will make that easier.
i might even suggest that we provide a convenience shortcut of specifying revision as a top level attribute, like so:
project[views][version] = 2.x-dev
project[views][revision] = "a6s5d4f6a5s4"
and drush make would internally set all the appropriate download settings.
Comments
Comment #1
moshe weitzman commentedSounds reasonable to me.
Comment #2
jhedstromI've added this, with an additional test (commit). Setting revision at the top level is now short-hand for download revision, so long as no other download parameters are specified.