Closed (fixed)
Project:
Drupal core
Version:
8.6.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Jul 2018 at 00:16 UTC
Updated:
30 Jul 2018 at 10:44 UTC
Jump to comment: Most recent
Problem/Motivation
Follow-up to #2278383: Create an injectible service for drupal_set_message()
Leftover @todo in element with ref to closed issue
Proposed resolution
remove the todo
Remaining tasks
review/commit
User interface changes
no
API changes
no
Data model changes
no
| Comment | File | Size | Author |
|---|---|---|---|
| 2278383-follow-up-2.patch | 635 bytes | andypost |
Comments
Comment #2
andypostComment #3
andypostComment #4
r.nabiullin commentedComment #5
alexpottWell someone needs to do the issue forensics to work out if the @todo has indeed been carried out - the @todo was added in #2289917: Convert "messages" page element into blocks and this code was not touched in #2278383: Create an injectible service for drupal_set_message() so how were things to be improved?
Comment #6
alexpottSo the @todo was added as a request in #2289917-127: Convert "messages" page element into blocks - BUT this was a bit strange. This is static code so I have no-idea how this was meant to be improved. Service injection into RenderElement objects is an issue in and of itself - so I guess removing the useless @todo is the thing to do.
Comment #7
alexpottCrediting myself for looking at the issue history and working out if removing the @todo was the correct thing to do.
Committed and pushed 92e2f1a3a4 to 8.7.x and 605b5ccfe8 to 8.6.x. Thanks!