jahmal [jahmal]

Hello, and thank you for applying for applying for a CVS account. I am adding the review tags, and somebody will report what needs to be changed in the module code.

Hi,

I've taken a little look at the module.

A few things I've noticed:

• No README.txt. Remember that if you're submitting this for community use there will be a lot of people who will only be admins (=non-programmers) who what to know what your module does, how to install it, what paths to go to in order to use it etc.
• Make the name consistent everywhere. I went to the module install page (admin/build/modules) and searched for "one2all" and found nothing. I had to search around till I found in the info file that there you call it "ActiveCampaign Email Marketing (1-2-All) Signup Box" so it is only that which appears on the module install page. I would suggest: "One2All, the ActiveCampaign Email Marketing (one 2 all) Signup Box".
• Run Coder module against the code (I saw Coder found 1 projects, 1 files, 332 normal warnings)

You can of course provide patches for as many modules you like without CVS access. If you're using 20 modules and find bugs with each of them (and better still can create patches for each of them), then you're not likely to end up being a co-maintainer of all 20 modules.

I don't think either that having CVS access allows you to commit patches to other people's modules. Anybody know the answer to that?

I don't think either that having CVS access allows you to commit patches to other people's modules.

It is necessary to have the permission (Drupal permission) to commit code in project repositories; this means that users with a CVS account can commit code in projects they created, or in projects they are accepted as co-maintainers (and the maintainer of those projects gave them the permission to commit code).

It is not necessary to attach patches to projects in this queue; we don't review patches.

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

As per previous comment, I am setting this issue as Won't fix.
Since users can now create full projects, applications have a different purpose and they are handled on a different issue queue. See Apply for permission to opt into security advisory coverage for more information.