Closed (fixed)
Project:
Views (for Drupal 7)
Version:
7.x-3.0-beta3
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Dec 2010 at 21:04 UTC
Updated:
24 Jul 2011 at 18:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
hadsie commentedComment #2
merlinofchaos commentedNo, $object->inline is set a few lines later. That set needs to move up.
Comment #3
dawehnerSo what about this one:
Should be commited to 6.x-3,x, too i guess.
Comment #4
danielb commentedJust spotted this too, and I agree with #2 and #3.
Comment #5
dawehnerHere is 6.x version, too.
Comment #6
pixelwhip commentedThe patch in #3 fixed this error for me, as well as a related issue of the inline separators not showing up at all in the Live Preview.
However, in addition to showing up in between field elements, the separator is showing up BEFORE the first field element of an inline group. This wasn't the case in 6.x as far as I know.
Comment #7
danielb commentedYes I have that problem too pixelwhip - I didn't realise it was unintentional.
Comment #8
dawehnerMove to d6.
Comment #9
pivica commentedHere is my patch for 7.x-3.x-dev. Everything seems to work fine with it, no problems like in #6. I will test more later and if I find some problems will report it here.
Comment #10
mzwyssig commented#9 seems to work for me (fresh upgraded D6 - views 2 to D7 - Views 3)
Comment #11
jcarlson34 commented@pivica thanks for #9. works great.
Comment #12
merlinofchaos commentedTry to remember to mark things 'needs review' when they have new patches. 'needs work' gets lost, as we assume that there's nothing here ready to review.
Comment #13
jcarlson34 commentedSorry about that merlinofchaos. Thank you for the clarification. Will mark patches as needs review when I see them with out it from now on.
I found this as great guide for anyone else who is interested: http://drupal.org/node/532400
Thanks for all your hard work. We really appreciate it!
Comment #14
mfblooks good. Tested w/ a view with separator and inline fields.
Comment #15
merlinofchaos commented#13: Amusingly, look at the text right below the status field. It has links. (I know, it's one of those things that you see every time you post so you quit seeing it's there).
Comment #16
jpincas commented#9 solved it for me too.
Comment #17
dawehnerLet's bring this into 6.x-3.x
Comment #18
danielb commentedJust FYI, this issue affects the views integration feature in Node reference and User reference fields.
Comment #19
blackdog commentedPatch in #9 solved this in 7.x-3.x.
Comment #20
dawehnerPlease don't move the version of the issue. This should be commited to 6.x-3.x, too.
Comment #21
Brakash commentedThe patch fixed it here as well. Not sure if it is related, but my separator has a space in front of it. Shouldn't it be right next to the left field being separated from the right? For example, if it is two fields city and state - it is showing up as city , state. I assume it should be city, state. If this is not the case can someone point me to a solution to fix this issue?
Comment #22
joelstein commentedThe patch in #9 solved my bug, but like #21, I also have an extra space before my separator.
Comment #23
Sborsody commentedI'm seeing this in Views 3 dev for Drupal 7 that was packaged sometime around March 8th. Has the patch been committed to Views-7.x-3.x-dev yet or not? I propose the issue is kept at the higher version number until then because I can't be the only one getting confused as to whether this patch is in 7 or not.
Comment #24
merlinofchaos commentedNo, a quick perusal of the issue shows that it has not been committed, and the issue status is "Reviewed & tested by the community" which means it is in the queue waiting for a final committer review.
Comment #25
jodeygrist commentedsubscribe.
Comment #26
merlinofchaos commented#9 appears to be the better patch, since I think $inline is used to determine if the previous field was inline. That is important.
Committed to 6.x-3.x and 7.x-3.x
Comment #28
steenbob commentedThis bug resurfaced for me today when I upgraded from the pre-rc1 build to rc1.
For every row in my view I get this pair:
EDIT: After some more experimentation, this may be a completely different bug. It seems to only occur when you try to use Panel Fields.
Comment #29
dawehnerThis is indeed a different issue. Please create a new one.
Comment #30
lauraleigh commentedI started with a clean install of D7.3/.4 and received the same error msg while working with panels in views:
Notice: Undefined index: default_field_elements in template_preprocess_views_view_fields() (line 179 of /home5/xxxx/public_html/testTEC/sites/all/modules/views/theme/theme.inc).
Notice: Undefined index: default_field_elements in template_preprocess_views_view_fields() (line 222 of /home5/xxxx/public_html/testTEC/sites/all/modules/views/theme/theme.inc).
In addition I'm also receiving: Notice: Undefined index: default_field_elements in template_preprocess_views_view_fields() (line 261 of /home5/xxxx/public_html/testTEC/sites/all/modules/views/theme/theme.inc).
Thank you dereine for the patch you provided in 1130300 it solved my issues!
Comment #31
dawehnerit's still a different issue....
Comment #32
lauraleigh commentedThank you dereine for the patch you provided in 1130300 it solved my issues!