I'm using the latest dev version of views 7 (2010-12-09) and since I upgraded I've been getting this notice:

Notice: Undefined property: stdClass::$inline in template_preprocess_views_view_fields() (line 207 of .../sites/all/modules/contrib/views/theme/theme.inc).

It looks like the $object no longer contains an inline attibute. This patch simply sets the inline attribute if one is not there.

Comments

hadsie’s picture

StatusFileSize
new545 bytes
merlinofchaos’s picture

Status: Needs review » Needs work

No, $object->inline is set a few lines later. That set needs to move up.

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new3.1 KB

So what about this one:

Should be commited to 6.x-3,x, too i guess.

danielb’s picture

Just spotted this too, and I agree with #2 and #3.

dawehner’s picture

StatusFileSize
new1000 bytes

Here is 6.x version, too.

pixelwhip’s picture

Status: Needs review » Needs work

The patch in #3 fixed this error for me, as well as a related issue of the inline separators not showing up at all in the Live Preview.

However, in addition to showing up in between field elements, the separator is showing up BEFORE the first field element of an inline group. This wasn't the case in 6.x as far as I know.

danielb’s picture

the separator is showing up BEFORE the first field element

Yes I have that problem too pixelwhip - I didn't realise it was unintentional.

dawehner’s picture

Version: 7.x-3.x-dev » 6.x-3.x-dev

Move to d6.

pivica’s picture

StatusFileSize
new979 bytes

Here is my patch for 7.x-3.x-dev. Everything seems to work fine with it, no problems like in #6. I will test more later and if I find some problems will report it here.

mzwyssig’s picture

#9 seems to work for me (fresh upgraded D6 - views 2 to D7 - Views 3)

jcarlson34’s picture

@pivica thanks for #9. works great.

merlinofchaos’s picture

Status: Needs work » Needs review

Try to remember to mark things 'needs review' when they have new patches. 'needs work' gets lost, as we assume that there's nothing here ready to review.

jcarlson34’s picture

Sorry about that merlinofchaos. Thank you for the clarification. Will mark patches as needs review when I see them with out it from now on.

I found this as great guide for anyone else who is interested: http://drupal.org/node/532400

Thanks for all your hard work. We really appreciate it!

mfb’s picture

Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Needs review » Reviewed & tested by the community

looks good. Tested w/ a view with separator and inline fields.

merlinofchaos’s picture

#13: Amusingly, look at the text right below the status field. It has links. (I know, it's one of those things that you see every time you post so you quit seeing it's there).

jpincas’s picture

#9 solved it for me too.

dawehner’s picture

Version: 7.x-3.x-dev » 6.x-3.x-dev

Let's bring this into 6.x-3.x

danielb’s picture

Just FYI, this issue affects the views integration feature in Node reference and User reference fields.

blackdog’s picture

Version: 6.x-3.x-dev » 7.x-3.x-dev

Patch in #9 solved this in 7.x-3.x.

dawehner’s picture

Version: 7.x-3.x-dev » 6.x-3.x-dev

Please don't move the version of the issue. This should be commited to 6.x-3.x, too.

Brakash’s picture

The patch fixed it here as well. Not sure if it is related, but my separator has a space in front of it. Shouldn't it be right next to the left field being separated from the right? For example, if it is two fields city and state - it is showing up as city , state. I assume it should be city, state. If this is not the case can someone point me to a solution to fix this issue?

joelstein’s picture

The patch in #9 solved my bug, but like #21, I also have an extra space before my separator.

Sborsody’s picture

I'm seeing this in Views 3 dev for Drupal 7 that was packaged sometime around March 8th. Has the patch been committed to Views-7.x-3.x-dev yet or not? I propose the issue is kept at the higher version number until then because I can't be the only one getting confused as to whether this patch is in 7 or not.

merlinofchaos’s picture

No, a quick perusal of the issue shows that it has not been committed, and the issue status is "Reviewed & tested by the community" which means it is in the queue waiting for a final committer review.

jodeygrist’s picture

subscribe.

merlinofchaos’s picture

Status: Reviewed & tested by the community » Fixed

#9 appears to be the better patch, since I think $inline is used to determine if the previous field was inline. That is important.

Committed to 6.x-3.x and 7.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

steenbob’s picture

Version: 6.x-3.x-dev » 7.x-3.0-rc1
Status: Closed (fixed) » Active

This bug resurfaced for me today when I upgraded from the pre-rc1 build to rc1.

For every row in my view I get this pair:

Notice: Undefined index: default_field_elements in template_preprocess_views_view_fields() (line 179 of /Applications/MAMP/htdocs/sites/all/modules/views/theme/theme.inc).
Notice: Undefined index: default_field_elements in template_preprocess_views_view_fields() (line 222 of /Applications/MAMP/htdocs/sites/all/modules/views/theme/theme.inc).

EDIT: After some more experimentation, this may be a completely different bug. It seems to only occur when you try to use Panel Fields.

dawehner’s picture

Version: 7.x-3.0-rc1 » 6.x-3.x-dev
Status: Active » Closed (fixed)

This is indeed a different issue. Please create a new one.

lauraleigh’s picture

StatusFileSize
new35.09 KB

I started with a clean install of D7.3/.4 and received the same error msg while working with panels in views:

Notice: Undefined index: default_field_elements in template_preprocess_views_view_fields() (line 179 of /home5/xxxx/public_html/testTEC/sites/all/modules/views/theme/theme.inc).
Notice: Undefined index: default_field_elements in template_preprocess_views_view_fields() (line 222 of /home5/xxxx/public_html/testTEC/sites/all/modules/views/theme/theme.inc).
In addition I'm also receiving: Notice: Undefined index: default_field_elements in template_preprocess_views_view_fields() (line 261 of /home5/xxxx/public_html/testTEC/sites/all/modules/views/theme/theme.inc).

Thank you dereine for the patch you provided in 1130300 it solved my issues!

dawehner’s picture

Version: 6.x-3.x-dev » 7.x-3.0-beta3

it's still a different issue....

lauraleigh’s picture

Thank you dereine for the patch you provided in 1130300 it solved my issues!