Closed (fixed)
Project:
Views (for Drupal 7)
Version:
6.x-3.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 Dec 2010 at 10:11 UTC
Updated:
24 Jan 2011 at 23:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
dawehnerUpdate status
Comment #2
dawehnerIt would be cool to provide a link to php.net so the user can inform what nl2br does.
Comment #3
helmo commentedGood point, I added the php.net link to the patch.
Comment #4
dawehnerEven i don't understand why you have to add target blank, the rest looks fine.
Comment #5
helmo commentedIf the target attribute were absent the php.net page would be loaded in the same window. Thus losing the current drupal page.
Comment #6
dawehnerPersonally people should be intelligent enough to use tabs.
Additional target isn't XHTML strict.
Comment #7
helmo commentedIn my case Firefox is clever enough to know I prefer them in a new tab.
But as for the xhtml strict spec... I've removed the target attribute from the patch.
What do you think about the rest of this patch?
Comment #8
merlinofchaos commentedThere's no need to expose nl2br() at all to the user. Telling them we'll convert newlines to br tags is good enough.
Comment #9
dawehnerRemove the comment about nl2br
Comment #10
helmo commented@merlinofchaos: I can understand that we should not overload the user with extra info.
Comment #11
merlinofchaos commentedCommitted to D6-3.x and D7-3.x