Currently, Discount coupons module only adds a conditional action to check if a coupon is applied. It does not allow checking if a particular coupon is applied. I modified the code to allow selection of coupon (if no coupon is selected, the default behavior will work which is to just check if any coupon is applied, so current installations should not be impacted). Also there seems to be a bug in current dev branch, when you check for used coupon reports you get a _uc_coupon_date_range not found because the uc_coupon.admin.inc was not getting included. I added a require in uc_coupon.reports.inc for the admin file. I posted the patch to show how can it be used to create a free shipping coupon at http://drupal.org/node/637814#comment-3794696.

Can this be reviewed and included in main stream.

Thanks

CommentFileSizeAuthor
patch_uc_coupon_coupon_selection_for_ca.patch2 KBnovice

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I would be more inclined to add a text field for coupon codes rather than a multiple select, as it could be difficult to manage for sites with lots of coupons. This would also allow the possibility of wildcards to match bulk coupons, or even different coupons that share the same prefix. Would this be a workable alternative?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

Changing status.

novice’s picture

novice commented

As such adding text field would be fine too, but makes it difficult if you have to select one of many. Could do comma separated etc. How about putting both selection + text field.

Thanks

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

By textfield I meant multiple lines; you could enter as many coupons as you like (one per line), and also possibly use * to indicate a wildcard.

novice’s picture

novice commented

That would work.

Thanks

novice’s picture

novice commented

Oh and BTW, when you are adding the code, could you please add the logic to not show the coupon discount in checkout, if the discount amount is 0.00, but still apply the coupon.

Thanks

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Fixed

This feature has been added and committed to CVS. The "order has a coupon applied" condition accepts any number of coupon codes to check for, including wildcard matches.

Please open a separate feature request for #6, I am not sure that all users will want this to happen and will have to consider it a bit more.

Status: Fixed » Closed (fixed)
Issue tags: -free shipping

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.