Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I have a view with grid style. After updating to the latest development snapshot I have noticed a bug in commit #459074.
The foreach
statement which applies the row classes has invalid arguments. I think the problem is that you used the raw $vars['rows']
for the first foreach
which contains just rows and $rows[$row_number]
inside it which contains rows with columns, so they don't match.
Comment | File | Size | Author |
---|---|---|---|
#7 | 989092-rows.patch | 4.85 KB | merlinofchaos |
#6 | 989092-rows.patch | 1.03 KB | dawehner |
#1 | views.989092_01.patch | 640 bytes | sgabe |
Comments
Comment #1
sgabe CreditAttribution: sgabe commentedI'm attaching a patch that replaces
$vars['rows']
with$rows
.Comment #2
dawehnerIt's fine. I'm wondering because i tested the patch 100%
Comment #3
jlmeredithI had the same error occurring. I can confirm that this patch resolved the issue for me.
Comment #4
yngens CreditAttribution: yngens commentedsubscribe
Comment #5
spelcheck CreditAttribution: spelcheck commentedPatch works for me, aok.
Comment #6
dawehnerHere is a new version which fixes the row-classes.
Still group-by doesn't work
Comment #7
merlinofchaos CreditAttribution: merlinofchaos commentedOk, got this sorted. Not sure why but the actual row index wasn't being carried through in grouping, so I had to modify stuff for that to continue to work. We need to watch for side effects.
Doesn't quite apply to D7, so marking for port. Patch attached.
Comment #8
dawehnerAnd ported.