CVS edit link for Stefan Vaduva

After I've took so much, it's time to give something back to the community.

My first module will be an IP.Board "bridge" that will allow Drupal 7 to use the IPB member table to authenticate users. I've posted the code on: http://groups.drupal.org/node/109904

Currently there is no SSO module for IP.Board 3. There is a module for IPB 2, but because the architecture of IP.Board has changed dramatically between this two version, I think that a new project will be better solution. And beside this, my module will not have all the functionality provided by the existing IPB2 module.

Thank you very much for your time.

Stefan Vaduva

CommentFileSizeAuthor
#5 ipbridge.zip1.98 KBstefan vaduva
#1 grind.zip1.67 KBstefan vaduva

Comments

stefan vaduva’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new1.67 KB

Grind is a SSO module that allows Drupal 7 to use IP.Board 3 member table to authenticate users.

avpaderno’s picture

Status: Needs review » Needs work
Issue tags: +Module review

Hello, and thank you for applying for a CVS account.

As per requirements, the motivation should include more than two sentences of module features, and a comparison with the existing solutions (where by solutions we mean any SSO module existing for Drupal).

stefan vaduva’s picture

Status: Needs work » Needs review

Thinking about this, maybe is not quite right to say is a SSO module (it does NOT authenticate users in both systems... it just authenticate users in Drupal using IPB username and password). A bridge module is a more accurate description.

Who is this module for
Drupal websites/communities that need to allow users registered in IPB to login in Drupal. The registration process and user mangament will still be handled by IP.Board.

How does it work
When a user wants to login using the standard Drupal login block/page, the system will check for the provided username in the standard Drupal user table. If a match is found, the standars validation/authentication will be made. If the user is not found, the system will also check IP.Board for a matching member. If one is found, it will be automatically logged in in Drupal.

- if a user exists in IPB but not in Drupal, the user will be able to login on both systems
- If a user exists in Drupal but not in IPB, that user WILL NOT be available in IPB

Installation
Add the IPB database in your settings.php (there is an example in readme.txt), enable the module and forget about it. For now there is no config page in Drupal, but depending on the direction this module will take, a config page will probably be present at some point

Compared with other IPB bridge modules
Invision (http://drupal.org/project/invision) is the only similar module.

The differences:

- my module is for IPB 3 while invision is for IPB 2 (the architecture is fundamentally different);
- in invision Drupal is managing users, in my module IPB is managing users;
- invision actually login the user in both system. Mine allows users to use the same username/password to login on both systems WITHOUT automatically login the user on one system when he login in the other system (no session sharing/manipulation).

brianV’s picture

Status: Needs review » Needs work

Hi Stefan!

A few notes:

  1. Please run your module through the Coder module code review. This will pick up a lot of coding standards, function misuse, security, and internationalization issues. See http://drupal.org/project/coder
  2. Please make sure all non-binary files have an @file documentation block as per http://drupal.org/node/1354#files
  3. Please make sure that your code commenting complies with the Drupal Doxygen guidelines as shown at http://drupal.org/node/1354 . This ensures that the API module and external sites like drupalcontrib.com can properly parse your code's documentation.
  4. Please make sure that the proper CVS $Id$ tags are added to all files as per http://drupal.org/handbook/cvs/faq. This requirement will be going away once we move from CVS to Git next year.
  5. Please don't include a 'version' line in your .info file. This is always added to the .info file by the Drupal.org CVS packaging script.
  6. Please rename readme.txt to README.txt.

Please consider naming your module something more relevant to the purpose of the module. 'Grind' doesn't tell anything about what the module is, or what it does.

stefan vaduva’s picture

Status: Needs work » Needs review
StatusFileSize
new1.98 KB

Done. Thanks everyone for the patience :)

brianV’s picture

Status: Needs review » Reviewed & tested by the community

Ok, this looks good!

avpaderno’s picture

Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

stefan vaduva’s picture

Wow. That was fast :)

I'm really excited about this. Thanks a lot and I hope that I'll be able to return the help at some point.

brianV’s picture

Stefan,

Don't hesitate to help with CVS application reviews - we could always use more :)

stefan vaduva’s picture

Ok. I'll do my best to help with this.

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.