Closed (fixed)
Project:
Drupal.org CVS applications
Component:
co-maintainer application
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
29 Nov 2010 at 21:30 UTC
Updated:
14 Apr 2019 at 08:48 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
avpadernoHello, and thank you for applying for a CVS account. Remember to attach in a comment here the code of the proposed module/theme.
Comment #2
hairqles commentedI've attached the fen filter module source.
Comment #3
avpadernoAs per requirements, the motivation should include a description of the module features, and a comparison with the existing solutions.
Comment #4
hairqles commentedComment #5
avpadernoComment #6
hairqles commentedThe FEN filter module define a simple content filter. You can enable the filter in the input formats. If you're using [fen:Forsyth–Edwards Notation] for example [fen:rnbqkbnr/pp1ppppp/8/2p5/4P3/8/PPPP1PPP/RNBQKBNR w KQkq c6 0 2] formulas in a content the filter draws the coded board position of a chess game. The filter output is a html table with the chess figures.
Comment #7
hairqles commentedComment #8
kalman.hosszu commentedHi hairqles!
Firstly, thanks for contributing, it's great to see people willing to share their work :)
Your code shows a great understanding of the Drupal API.
I've run your fen_filter module through coder module which has reported 2 normal warnings. The warnings are about coding style - having a consistent coding style makes it easier for the community to share, understand and test code, so we'd prefer to see all contributions at least passing the coder module's tests.
I think the final tabe rendering in fen_filter_process() should be done via a theme function, so that designers could easily change how the chessboard looks.
If a module is part of a collection of modules - for example CCK, ImageField, and Email Field - that all belong together. If it's a stand-alone module, then the package parameter can be left out.
I hope you find this feedback useful, and thanks again for getting involved!
Comment #9
hairqles commentedHi hosszu.kalman!
First of all thanks for your feedback.
I fixed the coding style warnings and the .info package stuff. I've taken your suggestion and now rendering via the hook_theme (fen_filter_theme) function. I also add classes to the pictures and table cells.
I'm looking forward any other suggestion.
cheers
Comment #10
hairqles commentedUnfortunately i've found a project that has the same functionality then my FEN filter module.
Comment #11
hairqles commentedHello,
I would like to apply for a CVS account to take over the maintenance the Case Tracker Timeline project. I already take the connection with the current maintainer via personal contact form.
cheers
hairqles
Comment #12
EvanDonovan commentedI am the current maintainer of the Case Tracker Timeline module, which has not yet been developed due to lack of time on the part of either person with commit access.
I have reviewed the code of the fen_filter.module as well, and I think that hairqles will do an excellent job developing the module.
Comment #13
avpadernoThank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #16
avpadernoComment #17
avpadernoI am giving credits to the users who actively participated in this issue.
Comment #19
avpaderno