Here's a patch which removes the need to escape quotes whenever possible, either by swapping the quotes, or else by expanding contractions.

There are still some possessives which I can't do anything about because they're in the same sentence as links.

Partial patch. Will get to the rest when I get home.

CommentFileSizeAuthor
#9 fix-escaped-quotes_2.patch39.61 KBwebchick
#7 fix-escaped-quotes_1.patch39.03 KBwebchick
#5 drupal_67.patch28.3 KBac
#3 drupal_66.patch28.3 KBac
#2 fix-escaped-quotes_0.patch21 KBwebchick
fix-escaped-quotes.patch32.31 KBwebchick
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented

There are some t() additions hiding in here.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
FileSize
fix-escaped-quotes_0.patch21 KB

Bah! Thanks, drumm.

Here is a re-rolled version up to but not including menu.module. Putting this here in case someone interested in mind-numbing tasks wants to take it from here. ;)

ac’s picture

ac
Primary language English
Location Perth
CreditAttribution: ac commented
FileSize
drupal_66.patch28.3 KB

I have removed the unnecessary escapes like you asked webchick. Is this what you wanted?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs work » Needs review

Just glancing through quickly, looks good to me!

ac’s picture

ac
Primary language English
Location Perth
CreditAttribution: ac commented
FileSize
drupal_67.patch28.3 KB

Slight mistake fixed

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Needs work

Looks good, but I totally forgot about \" :P Rolling some more...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs work » Needs review
FileSize
fix-escaped-quotes_1.patch39.03 KB

Let's try this.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Needs work

Ouch. Lots of failed hunks. Re-rolling.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs work » Needs review
FileSize
fix-escaped-quotes_2.patch39.61 KB

Let's try this again.

It's worth noting that this and the Move HTML out of strings wherever possible patch are going to collide in many places, so the sooner one of them gets committed, the sooner the other can get cleaned up.

Dries’s picture

Dries CreditAttribution: Dries commented
Priority: Critical » Normal
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)