No brainer patch attached :)

CommentFileSizeAuthor
bartik-erroneous-bracket.patch285 bytesamateescu

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

I had tried to catch this (multiple times :) ) in #889256: Clean up CSS coding style, but this is worth getting in on it's own.

amateescu’s picture

amateescu commented

Oh, totally forgot about that issue :)

Well, let's see what webchick or Dries have to say about this. I think #889256: Clean up CSS coding style should be a priority over this one.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

After rolling that patch 10 times, I have a half-dozen regular expressions that take care of most of that, I'm just waiting to get a couple of the CNR patches in first.

amateescu’s picture

amateescu commented

You're right, it won't be fun to reroll all the work i've done in the past couple of days.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

Not sure how committing a one-line patch is going to cause a re-roll of all the work you've done in the past couple of days..? Anyway, hope that was an exaggeration.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

We were referring to my 35KB monster coding style patch, which is less important after this commit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.