I think in the past, updatedb would only run if updatecode did something. Now, it runs if there are no code updates available. It does not run if the user answers "no" to the confirmation prompt when there are updates available.

CommentFileSizeAuthor
#4 drush-982098.patch737 bytesjonhattan
#2 drush-updatedb-only-after-updates-2.patch696 bytesgreg.1.anderson
#1 drush-updatedb-only-after-updates.patch1.98 KBgreg.1.anderson

Comments

greg.1.anderson’s picture

greg.1.anderson commented
Category: bug » feature
Priority: Normal » Minor
Status: Active » Needs review
StatusFileSize
new drush-updatedb-only-after-updates.patch1.98 KB

I looked at the code, and it seems my memory was wrong; updatedb was always called after updatecode, even if no code updates were made. This patch corrects that.

greg.1.anderson’s picture

greg.1.anderson commented
StatusFileSize
new drush-updatedb-only-after-updates-2.patch696 bytes

Better patch. #0 includes changes for a different issue with pm-updatecode that I'm not finished testing yet.

moshe weitzman’s picture

moshe weitzman commented
Assigned: Unassigned » jonhattan

Is the updatecode change needed here? Maybe that snuck into the patch.

This makes sense to me. Would be good to get jonhattan's review.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
StatusFileSize
new drush-982098.patch737 bytes

DRUSH_PM_CORE_UPDATE_AVAILABLE is not the best context to check here. It is only set if there're updates for both core and contrib.

DRUSH_PM_UPDATED is set when any project is efectively updated.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
Priority: Minor » Major
greg.1.anderson’s picture

greg.1.anderson commented
Status: Needs review » Fixed

Committed. Also added the same check to pm-updatecode, to skip the notify if there is nothing to notify about.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.