I am completely new to Drupal / Views. I am running Drupal off CVS and Views 6.x-3.x-dev. When I added my own custom content-type and displayed it on a page I ran into two issues:

notice: Undefined property: views_plugin_row_fields::$field_alias in drupal\sites\all\modules\views\plugins\views_plugin_row.inc on line 137.

as well as:

notice: Undefined index: distinct in drupal\sites\all\modules\views\plugins\views_plugin_query_default.inc on line 1070.

Version of PHP 5.3.3 with E_ALL & ^E_DEPRECATED. I am not sure what the official way of handling these is, but here is the patch I applied on my copy (with absolutely no idea what I am doing).

CommentFileSizeAuthor
#2 978874.patch503 bytesbojanz
views.patch1.23 KBStanAngeloff

Comments

redndahead’s picture

redndahead commented
Status: Active » Needs review

I'm seeing the same thing as the first notice. php 5.2, but I'm using alpha3 so not sure if it's fixed by now.

bojanz’s picture

bojanz commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 978874.patch503 bytes

The first part of the patch is valid.
The second is no longer needed.

So, a reroll with just the first part, and a RTBC.

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Committed to 3.x.

Can someone confirm this does not affect 2.x?

dawehner’s picture

dawehner
Primary language German
commented 
    if ($this->get_option('distinct')) {
      $this->view->query->set_distinct();
    }

There will be no index involved here. So it's fine.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.