* Note that for performance reasons, this method is only invoked for forms,
   * which receive the entity_type as first argument. Thus any forms added, must
   * follow that pattern.

The comma after 'forms' is crucial to meaning. Right now the sentence means ALL forms -- I assume what it's trying to say is ONLY the forms which receive the entity_type as first argument. For it to mean that, remove the comma. With the comma, you are adding information (like saying "for forms, which by the way..."), but without it you are specifying.

The comma after 'added' is incorrect too, but doesn't affect meaning.

Patch coming.

CommentFileSizeAuthor
#6 entity-comma-977372-6.patch696 bytesjacob.embree
#1 977372.entity.hook_forms-commas.patch686 bytesjoachim
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Active » Needs review
FileSize
977372.entity.hook_forms-commas.patch686 bytes

Here's the patch.

Status: Needs review » Needs work

The last submitted patch, 977372.entity.hook_forms-commas.patch, failed testing.

joachim’s picture

joachim CreditAttribution: joachim commented

Bot is clearly on crack today :/

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs work » Needs review

Back to review.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs review » Needs work

Make sure that you create your patches with git diff --no-prefix

jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
entity-comma-977372-6.patch696 bytes

Reroll but fixes a misplaced modifier in the same sentence.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Reviewed & tested by the community

Looks good. Thanks for the reroll!

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed.

  • jacob.embree authored a9790ee on 7.x-1.x 
    Issue #977372 by joachim, jacob.embree: grammar in docs - stray commas

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.