* Note that for performance reasons, this method is only invoked for forms,
* which receive the entity_type as first argument. Thus any forms added, must
* follow that pattern.
The comma after 'forms' is crucial to meaning. Right now the sentence means ALL forms -- I assume what it's trying to say is ONLY the forms which receive the entity_type as first argument. For it to mean that, remove the comma. With the comma, you are adding information (like saying "for forms, which by the way..."), but without it you are specifying.
The comma after 'added' is incorrect too, but doesn't affect meaning.
Patch coming.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | entity-comma-977372-6.patch | 696 bytes | jacob.embree |
| #1 | 977372.entity.hook_forms-commas.patch | 686 bytes | joachim |
Comments
Comment #1
joachim commentedHere's the patch.
Comment #3
joachim commentedBot is clearly on crack today :/
Comment #4
joachim commentedBack to review.
Comment #5
klausiMake sure that you create your patches with git diff --no-prefix
Comment #6
jacob.embree commentedReroll but fixes a misplaced modifier in the same sentence.
Comment #7
joachim commentedLooks good. Thanks for the reroll!
Comment #8
fagoThanks, committed.