The default value for contact_default_status in contact_form_user_admin_settings_alter() is not set to the actual variable value, it is always 1. Fix is simple, patch is attached :)

CommentFileSizeAuthor
#4 973488_contact-wrong-default-value.patch821 bytesamateescu
contact-wrong_default.patch556 bytesVolx

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Project: Contact » Drupal core
Version: 6.x-2.x-dev » 7.x-dev
Component: Code » contact.module
Assigned: Unassigned » dave reid
Priority: Normal » Critical
Status: Needs review » Needs work

Actually this needs to be fixed in core since we didn't fix this with the smart system_settings_form rollback.

montesq’s picture

montesq commented
Status: Needs work » Needs review

contact-wrong_default.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, contact-wrong_default.patch, failed testing.

amateescu’s picture

amateescu commented
Assigned: dave reid » amateescu
Status: Needs work » Needs review
StatusFileSize
new 973488_contact-wrong-default-value.patch821 bytes

Patch for D7.

bleen’s picture

bleen commented
Status: Needs review » Reviewed & tested by the community

patched against HEAD ... works as advertised.

... I'm not sure this is really critical, but at this point, who cares? RTBC

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Priority: Critical » Minor

Grrrr.

Guys. Critical means "If we don't fix it by RC, people will die."

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Yeah, this is not critical. The fix is proper though so I committed it to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.